Skip to content

Strip internal headers#37215

Closed
howardjohn wants to merge 2 commits intoistio:masterfrom
howardjohn:pilot/strip-internal-headers
Closed

Strip internal headers#37215
howardjohn wants to merge 2 commits intoistio:masterfrom
howardjohn:pilot/strip-internal-headers

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Feb 8, 2022 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Feb 8, 2022
@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2022
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Feb 8, 2022

/test all

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 8, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 8, 2022

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio 92d11ee link true /test lint_istio
gencheck_istio 92d11ee link true /test gencheck_istio
unit-tests_istio 92d11ee link true /test unit-tests_istio
integ-ipv6_istio 92d11ee link true /test integ-ipv6_istio
integ-pilot-istiodremote_istio 92d11ee link true /test integ-pilot-istiodremote_istio
integ-distroless_istio 92d11ee link true /test integ-distroless_istio
integ-pilot-istiodremote-mc_istio 92d11ee link true /test integ-pilot-istiodremote-mc_istio
integ-cni_istio 92d11ee link true /test integ-cni_istio
integ-pilot-multicluster_istio 92d11ee link true /test integ-pilot-multicluster_istio
integ-pilot_istio 92d11ee link true /test integ-pilot_istio
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2022
howardjohn added a commit to howardjohn/api that referenced this pull request Feb 8, 2022
@howardjohn
Add controls around injected headers
33249a1 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
@howardjohn howardjohn mentioned this pull request Feb 8, 2022
Merged
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 4, 2022
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 4, 2022

@howardjohn: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label Mar 11, 2022
@istio-policy-bot
Copy link
Copy Markdown

istio-policy-bot commented Mar 26, 2022

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-02-08. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Mar 26, 2022
howardjohn added a commit to howardjohn/api that referenced this pull request Aug 29, 2022
@howardjohn
Add controls around injected headers
5b2fb4b 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
howardjohn added a commit to howardjohn/api that referenced this pull request Feb 7, 2023
@howardjohn
Add controls around injected headers
463cf3a 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
howardjohn added a commit to howardjohn/api that referenced this pull request May 15, 2023
@howardjohn
Add controls around injected headers
bd0fcde 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
howardjohn added a commit to howardjohn/api that referenced this pull request Jul 21, 2023
@howardjohn
Add controls around injected headers
0349025 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
howardjohn added a commit to howardjohn/api that referenced this pull request Aug 9, 2023
@howardjohn
Add controls around injected headers
94bf0f8 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
istio-testing pushed a commit to istio/api that referenced this pull request Aug 11, 2023
@howardjohn
Add controls around injected headers (#2240)
7c4ff78 
* Add controls around injected headers

This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected

* address comments

* xfcc
istio-testing pushed a commit to istio-testing/api that referenced this pull request Aug 14, 2023
@howardjohn @istio-testing
Add controls around injected headers
a6d650c 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
howardjohn added a commit to istio-testing/api that referenced this pull request Aug 21, 2023
@howardjohn
Add controls around injected headers
a71784d 
This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected
istio-testing added a commit to istio/api that referenced this pull request Aug 21, 2023
@istio-testing @howardjohn
[release-1.19] Add controls around injected headers (#2902)
6d232ba 
* Add controls around injected headers

This PR adds controls to which headers should be added to
requests/responses. This solves (most of)
istio/istio#17635, a common feature request.

A prototype is implemented in istio/istio#37215.

Open questions:
* Naming bikeshed
* Mesh config or proxy config or something else? Currently its in proxy
  config
* Is a list of ENUMs the best way to represent this? it does allow a
  strange config like `[REQUEST_ID, REQUEST_ID]` but that can just
rejected

* address comments

* xfcc

---------

Co-authored-by: John Howard <howardjohn@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@howardjohn @istio-testing @istio-policy-bot