[release-1.19] Add controls around injected headers#2902
Merged
istio-testing merged 3 commits intoistio:release-1.19from Aug 21, 2023
Merged
[release-1.19] Add controls around injected headers#2902istio-testing merged 3 commits intoistio:release-1.19from
istio-testing merged 3 commits intoistio:release-1.19from
Conversation
Member
|
/retest |
Contributor
|
Needs manual make gen? |
Member
|
Also, should this be merged together once the implementation has been merged and cherry-picked? |
|
@howardjohn can you follow up on this? needs a makegen |
This PR adds controls to which headers should be added to requests/responses. This solves (most of) istio/istio#17635, a common feature request. A prototype is implemented in istio/istio#37215. Open questions: * Naming bikeshed * Mesh config or proxy config or something else? Currently its in proxy config * Is a list of ENUMs the best way to represent this? it does allow a strange config like `[REQUEST_ID, REQUEST_ID]` but that can just rejected
914852c to
4146873
Compare
ksubrmnn
approved these changes
Aug 21, 2023
howardjohn
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2240