Fix the grafana service account, missing namespace.#3522
Fix the grafana service account, missing namespace.#3522ldemailly merged 1 commit intoistio:masterfrom
Conversation
|
Hi @jeffmendoza. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
|
/assign @douglas-reid |
|
/ok-to-test |
|
/test e2e-simple We renamed e2e-smoke to e2e-bookInfo and added e2e-simple |
|
@jeffmendoza i'm not an RBAC expert -- are there perms that we think we should be enabling here? |
|
/test istio-pilot-e2e.sh |
|
After some quick education, I don't believe we need a role or role binding as Grafana does not need to access any k8s apiserver endpoints. |
|
/test istio-pilot-e2e |
879b6fc to
4ca809d
Compare
|
@douglas-reid Tests are green (hopefully they pass retest!) ptal. |
Grafana is currently broken. #2465 is missing the namespace, similar to the recent problem with Prometheus.
Do we need a
ClusterRoleandClusterRoleBinding?