Specify ServiceAccount for Grafana by geoand · Pull Request #2465 · istio/istio

geoand · 2018-01-08T14:06:40Z

This is useful to facilitate deployment on Openshift where the scc can be given to anyuid for the specific
ServiceAccounts, instead of having to give it to the default ServiceAccount.

googlebot · 2018-01-08T14:06:43Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

istio-testing · 2018-01-08T14:06:47Z

Hi @geoand. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The documentation change here reflects the work that was done on: istio/istio#2465 and should only be merged IFF the aforementioned PR is merged

rshriram · 2018-01-12T01:55:40Z

/ok-to-test

douglas-reid

/lgtm

istio-merge-robot · 2018-01-13T07:27:47Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @douglas-reid @geoand

geoand · 2018-01-13T07:28:46Z

I signed it!

ldemailly · 2018-01-13T07:30:44Z

tip: don't push -f when you update a pr as this loses the history

The documentation change here reflects the work that was done on: istio/istio#2465 and should only be merged IFF the aforementioned PR is merged

geoand · 2018-01-13T07:36:32Z

@ldemailly Sorry about that... The only reason I forced push is because I needed to change the author of the commit for the purposed of the CLA

The documentation change here reflects the work that was done on: istio/istio#2465 and should only be merged IFF the aforementioned PR is merged

douglas-reid · 2018-01-16T16:52:49Z

/lgtm

istio-merge-robot · 2018-01-24T08:01:53Z

@geoand PR needs rebase

istio-merge-robot · 2018-01-24T18:19:08Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @douglas-reid @geoand

ldemailly · 2018-01-24T18:36:57Z

/lgtm

istio-merge-robot · 2018-02-02T16:45:38Z

/test all [submit-queue is verifying that this PR is safe to merge]

istio-merge-robot · 2018-02-04T08:01:27Z

@geoand PR needs rebase

istio-merge-robot · 2018-02-04T09:30:32Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @douglas-reid @geoand @ldemailly

sdake · 2018-02-04T22:31:25Z

/test istio-pilot-e2e

sdake · 2018-02-04T22:31:45Z

/lgtm

istio-merge-robot · 2018-02-04T22:32:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: douglas-reid, ldemailly, sdake

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [douglas-reid,ldemailly]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

geoand · 2018-02-05T16:18:04Z

/test istio-pilot-e2e

andraxylia · 2018-02-06T05:33:42Z

@geoand please resolve conflicts so this PR can be merged, or close it otherwise.

istio-merge-robot · 2018-02-06T05:33:49Z

@geoand PR needs rebase

ldemailly · 2018-02-06T05:34:45Z

the file is gone so the change needs to be in the template instead of this file

This is useful to facilitate deployment on Openshift where the scc can be given to anyuid for the specific ServiceAccounts, instead of having to give it to the default ServiceAccount.

istio-merge-robot · 2018-02-06T07:15:23Z

/lgtm cancel //PR changed after LGTM, removing LGTM. @douglas-reid @geoand @ldemailly @sdake

istio-testing · 2018-02-06T08:29:18Z

@geoand: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
prow/istio-pilot-e2e.sh	`7581999`	link	`/test istio-pilot-e2e`

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jan 8, 2018

istio-testing added the needs-ok-to-test label Jan 8, 2018

geoand mentioned this pull request Jan 8, 2018

Change the installation instructions for Openshift istio/istio.io#856

Merged

istio-testing removed the needs-ok-to-test label Jan 12, 2018

rshriram requested a review from douglas-reid January 12, 2018 01:55

douglas-reid reviewed Jan 12, 2018

View reviewed changes

istio-testing assigned douglas-reid Jan 12, 2018

istio-testing added the lgtm label Jan 12, 2018

istio-merge-robot added the approved label Jan 12, 2018

geoand force-pushed the ServiceAccount branch from 3c43257 to 3446397 Compare January 13, 2018 07:26

istio-merge-robot removed the lgtm label Jan 13, 2018

istio-testing added the lgtm label Jan 16, 2018

istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Jan 24, 2018

geoand force-pushed the ServiceAccount branch from 3446397 to 9fc32fe Compare January 24, 2018 18:18

istio-merge-robot removed lgtm needs-rebase Indicates a PR needs to be rebased before being merged labels Jan 24, 2018

istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 4, 2018

geoand force-pushed the ServiceAccount branch from 0927647 to 180a9c8 Compare February 4, 2018 09:29

istio-merge-robot removed lgtm needs-rebase Indicates a PR needs to be rebased before being merged labels Feb 4, 2018

geoand changed the title ~~Specify ServiceAccounts for Prometheus and Grafana~~ Specify ServiceAccounts for Grafana Feb 4, 2018

geoand changed the title ~~Specify ServiceAccounts for Grafana~~ Specify ServiceAccount for Grafana Feb 4, 2018

istio-testing assigned sdake Feb 4, 2018

istio-testing added the lgtm label Feb 4, 2018

gyliu513 approved these changes Feb 5, 2018

View reviewed changes

istio-merge-robot added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 6, 2018

Specify ServiceAccounts for Grafana

7581999

This is useful to facilitate deployment on Openshift where the scc can be given to anyuid for the specific ServiceAccounts, instead of having to give it to the default ServiceAccount.

geoand force-pushed the ServiceAccount branch from 180a9c8 to 7581999 Compare February 6, 2018 07:14

istio-merge-robot removed lgtm needs-rebase Indicates a PR needs to be rebased before being merged labels Feb 6, 2018

andraxylia merged commit 8bcb320 into istio:master Feb 9, 2018

jeffmendoza mentioned this pull request Feb 15, 2018

Fix the grafana service account, missing namespace. #3522

Merged

geoand deleted the ServiceAccount branch March 31, 2018 17:01

Conversation

geoand commented Jan 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Jan 8, 2018

Uh oh!

istio-testing commented Jan 8, 2018

Uh oh!

rshriram commented Jan 12, 2018

Uh oh!

douglas-reid left a comment

Choose a reason for hiding this comment

Uh oh!

istio-merge-robot commented Jan 13, 2018

Uh oh!

geoand commented Jan 13, 2018

Uh oh!

ldemailly commented Jan 13, 2018

Uh oh!

geoand commented Jan 13, 2018

Uh oh!

douglas-reid commented Jan 16, 2018

Uh oh!

istio-merge-robot commented Jan 24, 2018

Uh oh!

istio-merge-robot commented Jan 24, 2018

Uh oh!

ldemailly commented Jan 24, 2018

Uh oh!

istio-merge-robot commented Feb 2, 2018

Uh oh!

istio-merge-robot commented Feb 4, 2018

Uh oh!

istio-merge-robot commented Feb 4, 2018

Uh oh!

sdake commented Feb 4, 2018

Uh oh!

sdake commented Feb 4, 2018

Uh oh!

istio-merge-robot commented Feb 4, 2018

Uh oh!

geoand commented Feb 5, 2018

Uh oh!

andraxylia commented Feb 6, 2018

Uh oh!

istio-merge-robot commented Feb 6, 2018

Uh oh!

ldemailly commented Feb 6, 2018

Uh oh!

istio-merge-robot commented Feb 6, 2018

Uh oh!

istio-testing commented Feb 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

geoand commented Jan 8, 2018 •

edited

Loading