Skip to content

add demos from amalgam8#3

Merged
rshriram merged 6 commits intoistio:masterfrom
frankbu:master
Jan 26, 2017
Merged

add demos from amalgam8#3
rshriram merged 6 commits intoistio:masterfrom
frankbu:master

Conversation

@frankbu
Copy link
Copy Markdown
Contributor

@frankbu frankbu commented Jan 17, 2017 •
edited by mandarjog
Loading

Stripped down version of the Amalgam8 demo applications and first pass at a demo outline for Istio milestone 1. Addresses Issue #2.

This change is Reviewable

rshriram
rshriram reviewed Jan 17, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the travis error as there is no travis configuration for this repository yet.

@rshriram rshriram mentioned this pull request Jan 17, 2017
Closed
@mandarjog
Copy link
Copy Markdown
Contributor

mandarjog commented Jan 25, 2017 •
edited
Loading 

   - dstCluster:
        name: serviceB
        tags:
        - env=prod 
      weight: 100
upstreamClusters:
- cluster:
    name: serviceB
    tags:
    - env=prod

It seems in order to match one of the upstream clusters, we enforce exact match of {name + tags }, if so same info is being repeated multiple times.

If not we need to add examples where dstCluster selects one or more upstream clusters based on partial name + tag matches.

@rshriram @frankbu

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jan 26, 2017

We need exact match. If there is a way to name the upstream cluster somewhere and use that name here, it would be great. Otherwise, we have to deal with this redundancy for the moment. It's documented in the proxy config

mandarjog
mandarjog approved these changes Jan 26, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There are several additions we need to make to this doc and demo.
None of this should hold up this PR.

  1. There are several TODOs in bookinfo.md.
  2. We want to showcase monitoring, so that bit needs to be worked in.
  3. We would also like to showcase rate limiting.

@rshriram rshriram merged commit 5c4c34d into istio:master Jan 26, 2017
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@lookuptable
Add SecretController that watches service accounts to create key & ce…
a23ab45 
…rt (#27)

* Add SecretController that watches service accounts to create key & cert

This is the first commit towards #3 .

* Add copyright headers
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@geeknoid
Fix copyright. (#3)
46304e8
mandarjog pushed a commit that referenced this pull request Oct 31, 2017
@kyessenov
Add RDS and CDS (#266)
2813b7a 
#3
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@rshriram
Merge pull request #3 from frankbu/master
662642a 
add demos from amalgam8
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
@lookuptable
Add SecretController that watches service accounts to create key & ce…
f204566 
…rt (#27)

* Add SecretController that watches service accounts to create key & cert

This is the first commit towards #3 .

* Add copyright headers
@kyessenov kyessenov mentioned this pull request Nov 3, 2017
Closed
@manlinl manlinl mentioned this pull request Nov 7, 2017
Closed
@ayj ayj mentioned this pull request Jan 10, 2018
Closed
@mattdelco mattdelco mentioned this pull request Jan 23, 2018
Merged
@kyessenov kyessenov mentioned this pull request Jan 27, 2018
Closed
@reynaldiwijaya reynaldiwijaya mentioned this pull request Feb 26, 2018
Closed
rshriram pushed a commit that referenced this pull request Apr 6, 2018
@ostromart @rshriram
Mixer filter fixes (#4718)
a585096 
* Mixer filter fixes

* Address review comments

* Changes to listener build, revert OnListener APIs

* Move buildListener just before callbacks

* Address review comments

* Address review comments #2

* Address comments #3

* Address review comments #4

* Change return to struct value
@hklai hklai mentioned this pull request May 1, 2018
Merged
@ostromart ostromart mentioned this pull request May 18, 2018
Closed
@costinm costinm mentioned this pull request Mar 2, 2020
Closed
@irisdingbj irisdingbj mentioned this pull request Apr 22, 2020
Merged
@rolandkool rolandkool mentioned this pull request Jun 11, 2020
Closed
@kyessenov kyessenov mentioned this pull request Aug 16, 2020
Closed
@ramaraochavali ramaraochavali mentioned this pull request Sep 10, 2020
Merged
@incfly incfly mentioned this pull request Oct 26, 2020
Merged
@ramaraochavali ramaraochavali mentioned this pull request Nov 16, 2020
Closed
@christian-posta christian-posta mentioned this pull request Dec 8, 2020
Closed
@ramaraochavali ramaraochavali mentioned this pull request Mar 4, 2021
Closed
@ericvn ericvn mentioned this pull request Mar 8, 2021
Closed
@rnkhouse rnkhouse mentioned this pull request Apr 8, 2021
Closed
@litong01 litong01 mentioned this pull request Jun 11, 2021
Closed
@dawo0od dawo0od mentioned this pull request Feb 1, 2022
Closed
15 tasks
@ericvn ericvn mentioned this pull request May 16, 2022
Open
@kyessenov kyessenov mentioned this pull request Jul 25, 2022
Closed
@LugiaChang LugiaChang mentioned this pull request Sep 19, 2022
Closed
16 tasks
@RaiAnandKr RaiAnandKr mentioned this pull request Jan 13, 2023
Closed
@kyessenov kyessenov mentioned this pull request Jan 19, 2023
Closed
@mallikkml mallikkml mentioned this pull request Oct 11, 2023
Closed
antonioberben pushed a commit to antonioberben/istio that referenced this pull request Jan 29, 2024
@naseemkullah
Merge pull request istio#3 from jpkrohling/Version-1.16.0
a64eb13 
Updated charts to use v1.16.0
@dhawton dhawton mentioned this pull request Jan 30, 2024
Closed
2 tasks
@netkey netkey mentioned this pull request Mar 7, 2024
Closed
2 tasks
@pavan359t pavan359t mentioned this pull request Sep 6, 2024
Closed
2 tasks
luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024
@openshift-merge-bot
Merge pull request istio#3 from openshift-service-mesh-bot/none-maste…
6d5ce30 
…r-merge_upstream_istio_master-6253864e

Automator: merge upstream changes to openshift-service-mesh/istio@master
johnlanni added a commit to johnlanni/istio that referenced this pull request Dec 26, 2024
@johnlanni
Merge pull request istio#3 from Erica177/merge_commerical
6b7a23a 
Merge commercial code into the isio repository
jewertow pushed a commit to jewertow/upstream-istio that referenced this pull request Jun 3, 2025
@sridhargaddam
Use escape chars for the script (istio#3)
cf3d0cc 
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
@AhmadMS1988 AhmadMS1988 mentioned this pull request Jan 30, 2026
Open
2 tasks
@garrettheel garrettheel mentioned this pull request Mar 5, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geeknoid geeknoid Awaiting requested review from geeknoid

2 more reviewers

@rshriram rshriram rshriram left review comments

@mandarjog mandarjog mandarjog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frankbu @mandarjog @rshriram @kyessenov @googlebot