Add Prometheus, Grafana and ServiceGraph by andraxylia · Pull Request #27 · istio/istio

andraxylia · 2017-03-07T01:37:19Z

This change is

douglas-reid

This mostly looks good to me. Curious about just pushing a new grafana image to save the ENV setting here.

douglas-reid · 2017-03-07T22:44:46Z

demos/kubernetes/README.md

+
+View the graph json data and image at:
+
+    http://<servicegraph-svc-external-IP>:8088/graph?time_horizon=600s


not blocking: if you want, you could also use 10m instead of 600s.

douglas-reid · 2017-03-07T22:45:51Z

demos/kubernetes/grafana.yaml

+    spec:
+      containers:
+      - name: grafana
+        image: gcr.io/istio-testing/grafana:demo


not blocking: we should consider pushing a new version that has the ENV settings to ease demo validation.

douglas-reid · 2017-03-07T22:46:19Z

demos/kubernetes/grafana.yaml

+      volumes:
+      - name: grafana-data
+        emptyDir: {}
+---


nit: you may want to add a newline at the end of this file.

douglas-reid · 2017-03-07T22:46:36Z

demos/kubernetes/grafana.yaml

+        env:
+        - name: GRAFANA_PORT
+          value: "3000"
+        - name: GF_AUTH_BASIC_ENABLED


see comment above about a new image for grafana.

douglas-reid · 2017-03-07T22:47:15Z

demos/kubernetes/prometheus.yaml

+      - name: config-volume
+        configMap:
+          name: prometheus
+---


nit: add newline at end of file.

kyessenov · 2017-03-08T03:43:02Z

demos/kubernetes/README.md

    kubectl apply -f ./istio -n <ns>

-This will deploy istio discovery manager and istio mixer.
+This will deploy istio manager discovery and istio mixer.


I think we can call it "discovery service". In reality, it combines what Envoy calls SDS, CDS, RDS, and in the future, LDS, which are all discovery services.

kyessenov · 2017-03-08T03:44:54Z

demos/kubernetes/README.md

+
+Grafana custom image contains a build-in Istio-dashboard that you can access from:
+
+    http://<grafana-svc-external-IP>:3000/dashboard/db/istio-dashboard


This is a question that always pops up - would be nice to avoid using LoadBalancer since minikube doesn't support on.

The only reason for which I used LoadBalancer is because the built-in istio-dashboard in grafana assumes direct access and not via the proxy. I added clarification in the readme file.

kyessenov

LGTM

rshriram · 2017-03-08T15:31:49Z

In the interest of consistency, can we try to consolidate the folders? we have demos/kubernetes/echo..., demos/apps/bookinfo.., demos/apps/helloworld[does not work].

It would be nice if we move the echo stuff into demos/apps/echo. And then get rid of helloworld simple app. The istio stuff should be one single control plane file, common to all folders (thats what we have under demos/controlplane.yaml .. This is not a blocker, but if you have the time for a cleanup, it would be worthwhile to make things consistent especially before a demo. :)

Add Prometheus, Grafana and ServiceGraph Former-commit-id: f2abe22

…rt (#27) * Add SecretController that watches service accounts to create key & cert This is the first commit towards #3 . * Add copyright headers

* Introduce service tags * Define service discovery interface

…rt (#27) * Add SecretController that watches service accounts to create key & cert This is the first commit towards #3 . * Add copyright headers

Add Prometheus, Grafana and ServiceGraph Former-commit-id: f2abe22

Fix istio repo location

Update spm config

* Recursive directory watcher * Fix initial timer value * Lint * Add copyright * Review comments * Add the codecov setup from istio repo (istio#32) * Add the codecov setup from istio repo * Add the codecov setup from istio repo * Extend CODEOWNERS (istio#37) * Add local codecov check script (istio#23) * Add local codecov check script * Add codecov diff check script to check coverage drop * Add codecov diff check script to check coverage drop * Update common files. (istio#39) * Add build infra for proto to Go structs (istio#34) * Add build infra for proto to Go structs * Add deepcopy for gogo types used in IstioControlPlane proto * Bypass deepcopy for DynamicAny, not used * WIP * Disable deepcopy until clean solution can be found * Minor updates * add resources or certmanager. (istio#45) * Add Environment WG leads to CODEOWNERS (istio#46) * Refactoring utils (istio#40) * Refactoring utils * Lint * Copyrights * Minor cleanup * Overview of component package group (istio#27) * Config and profile samples (istio#38) * Config and profile samples * Update profiles and sample * Additional fields * Default profile comes from compiled in * Listen also for create and delete events

* update Envoy sha (#25) * update Envoy sha * update sha again * Bump base image (#27) * Update proxy sha Co-authored-by: Yangmin Zhu <ymzhu@google.com> Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>

) * Push distroless images when helm test are executed * Update integ-suite-ocp.sh to use variant

Add Prometheus and Grafana

1ddbd69

googlebot added the cla: yes label Mar 7, 2017

Add service graph template

006ebad

andraxylia changed the title ~~Add Prometheus and Grafana~~ Add Prometheus, Grafana and ServiceGraph Mar 7, 2017

andraxylia requested a review from douglas-reid March 7, 2017 02:36

douglas-reid reviewed Mar 7, 2017

View reviewed changes

Add newline at the end of file

71e61af

kyessenov reviewed Mar 8, 2017

View reviewed changes

andraxylia added 2 commits March 7, 2017 20:12

Rename to discovery service

2de2448

Added NodePort clarification

6b031a7

kyessenov approved these changes Mar 8, 2017

View reviewed changes

andraxylia merged commit f2abe22 into master Mar 8, 2017

rshriram pushed a commit that referenced this pull request Oct 30, 2017

Merge pull request #27 from istio/k8s_demo

9058235

Add Prometheus, Grafana and ServiceGraph Former-commit-id: f2abe22

mandarjog pushed a commit that referenced this pull request Oct 31, 2017

Introduce service tags (#27)

e9b3553

* Introduce service tags * Define service discovery interface

mandarjog pushed a commit that referenced this pull request Nov 2, 2017

Merge pull request #27 from istio/k8s_demo

fd10562

Add Prometheus, Grafana and ServiceGraph Former-commit-id: f2abe22

reynaldiwijaya mentioned this pull request Feb 26, 2018

Omitting listener for management address #1194

Closed

JimmyCYJ mentioned this pull request May 30, 2018

envoy v2 crashes during TestIngressGateway503DuringRuleChange #5694

Closed

rajusharma pushed a commit to rajusharma/istio that referenced this pull request Jul 2, 2019

Merge pull request istio#27 from howardjohn/makefile-github-folder

a74e965

Fix istio repo location

jplevyak mentioned this pull request Sep 12, 2019

istio 1.2.4: envoy segfaults occasionally on istio-proxy pods #16357

Closed

jplevyak mentioned this pull request Oct 9, 2019

Istio 1.3.1 - Envoy segfaults #17699

Closed

vikaschoudhary16 pushed a commit to vikaschoudhary16/istio that referenced this pull request Oct 11, 2019

Merge pull request istio#27 from tetrateio/gao-spm-config

d9828f5

Update spm config

lei-tang mentioned this pull request Dec 2, 2019

Error connecting to Pilot using Vault CA #18927

Closed

howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020

Overview of component package group (istio#27)

50b4ac7

kyessenov mentioned this pull request Jun 12, 2020

Envoy segfaults and restarts with multi cluster installation #24605

Closed

brian-avery pushed a commit that referenced this pull request Jun 30, 2020

Bump base image (#27)

58f551e

kyessenov mentioned this pull request Jul 25, 2022

Crash in stackdriver when reloaded with LDS #40101

Closed

LugiaChang mentioned this pull request Sep 19, 2022

Envoy core dumped #41045

Closed

16 tasks

netkey mentioned this pull request Mar 7, 2024

Envoy exited with error: signal: segmentation fault #49777

Closed

2 tasks

pavan359t mentioned this pull request Sep 6, 2024

GCP istio proxy is crashing #53028

Closed

2 tasks

luksa pushed a commit to luksa/istio that referenced this pull request Oct 14, 2024

Push distroless images when helm integration test are executed (istio#27

d5cabdb

) * Push distroless images when helm test are executed * Update integ-suite-ocp.sh to use variant

johnlanni pushed a commit to johnlanni/istio that referenced this pull request Jun 17, 2025

fix: enable lds cache (istio#27)

5a5aa49

dgn pushed a commit to dgn/istio that referenced this pull request Jun 24, 2025

Push distroless images when helm integration test are executed (istio#27

16d27ae

) * Push distroless images when helm test are executed * Update integ-suite-ocp.sh to use variant

cam-garrison pushed a commit to cam-garrison/istio that referenced this pull request Oct 29, 2025

Push distroless images when helm integration test are executed (istio#27

dec0d86

) * Push distroless images when helm test are executed * Update integ-suite-ocp.sh to use variant

cam-garrison pushed a commit to cam-garrison/istio that referenced this pull request Jan 20, 2026

Push distroless images when helm integration test are executed (istio#27

5250b3a

) * Push distroless images when helm test are executed * Update integ-suite-ocp.sh to use variant

dgn pushed a commit to dgn/istio that referenced this pull request Feb 17, 2026

Push distroless images when helm integration test are executed (istio#27

2306bad

) * Push distroless images when helm test are executed * Update integ-suite-ocp.sh to use variant


		View the graph json data and image at:

		http://<servicegraph-svc-external-IP>:8088/graph?time_horizon=600s


		Grafana custom image contains a build-in Istio-dashboard that you can access from:

		http://<grafana-svc-external-IP>:3000/dashboard/db/istio-dashboard

Conversation

andraxylia commented Mar 7, 2017 • edited by mandarjog Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

douglas-reid left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kyessenov left a comment

Choose a reason for hiding this comment

Uh oh!

rshriram commented Mar 8, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andraxylia commented Mar 7, 2017 •

edited by mandarjog

Loading