Skip to content

[Release-1.5] [Helm Install] Fix extra .Value in deployment file for stackdriver tracing vars#21486

Merged
istio-testing merged 1 commit intoistio:release-1.5from
gargnupur:nup_fix_vars1.5
Feb 25, 2020
Merged

[Release-1.5] [Helm Install] Fix extra .Value in deployment file for stackdriver tracing vars#21486
istio-testing merged 1 commit intoistio:release-1.5from
gargnupur:nup_fix_vars1.5

Conversation

@gargnupur
Copy link
Copy Markdown
Contributor

@gargnupur gargnupur commented Feb 25, 2020

Fix extra .Value in deployment file for stackdriver tracing vars
Ref: #21218

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@gargnupur gargnupur requested review from a team and howardjohn February 25, 2020 21:07
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 25, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 25, 2020
@istio-testing istio-testing merged commit 360490c into istio:release-1.5 Feb 25, 2020
@gargnupur gargnupur deleted the nup_fix_vars1.5 branch February 27, 2020 07:05
gargnupur referenced this pull request Mar 26, 2020
* Fix malformed stackdriver tracing env var

Ref: #20851

* Run make gen

* Run make gen

* Fix test added
@istio-testing
Copy link
Copy Markdown
Collaborator

In response to a cherrypick label: new pull request created: #22506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test and release cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants