Fix malformed stackdriver tracing env var#21005
Merged
istio-testing merged 4 commits intoistio:masterfrom Feb 11, 2020
Merged
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
bianpengyuan
approved these changes
Feb 10, 2020
Contributor
Author
Test coming in, different PR.. don't want to cause merge conflicts because of a new test in cherry-picks.. |
howardjohn
requested changes
Feb 10, 2020
pkg/bootstrap/option/instances.go
Outdated
| } | ||
|
|
||
| func StackDriverMaxAnnotations(value int64) Instance { | ||
| //return newOption("stackdriverMaxAnnotations", value).withConvert(int64Converter(value)) |
Contributor
Author
There was a problem hiding this comment.
Those files were added by a bad commit.. they are removed now
pkg/test/util/retry/retry.go
Outdated
| t.Helper() | ||
| err := UntilSuccess(fn, options...) | ||
| if err != nil { | ||
| time.Sleep(time.Minute * 10) |
Contributor
Author
There was a problem hiding this comment.
Those files were added by a bad commit.. they are removed now
| retry.UntilSuccessOrFail(t, func() error { | ||
| util.SendTraffic(ingInst, t, "Sending traffic", "", "", 1) | ||
|
|
||
| return fmt.Errorf("cannot get traces from stackdriver %v", bookinfoNsInst) |
Member
There was a problem hiding this comment.
how is this testing stack driver?
Contributor
Author
There was a problem hiding this comment.
It had tracing enabled through stackdriver but it's not complete yet and I will add the test in a different PR.
Those files were added by a bad commit.. they are removed now
howardjohn
approved these changes
Feb 10, 2020
elfinhe
approved these changes
Feb 10, 2020
Contributor
Author
|
/test integ-telemetry-k8s-tests_istio |
Collaborator
|
In response to a cherrypick label: #21005 failed to apply on top of branch "release-1.4": |
Collaborator
|
In response to a cherrypick label: #21005 failed to apply on top of branch "release-1.5": |
gargnupur
added a commit
to gargnupur/istio
that referenced
this pull request
Feb 13, 2020
* Fix malformed stackdriver tracing env var Ref: istio#20851 * Run make gen * Run make gen * Fix test added
gargnupur
added a commit
to gargnupur/istio
that referenced
this pull request
Feb 13, 2020
* Fix malformed stackdriver tracing env var Ref: istio#20851 * Run make gen * Run make gen * Fix test added
This was referenced Feb 13, 2020
istio-testing
pushed a commit
that referenced
this pull request
Feb 13, 2020
istio-testing
pushed a commit
that referenced
this pull request
Feb 14, 2020
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Feb 21, 2020
* Fix malformed stackdriver tracing env var Ref: istio#20851 * Run make gen * Run make gen * Fix test added
brian-avery
pushed a commit
to brian-avery/istio
that referenced
this pull request
Mar 4, 2020
* Fix malformed stackdriver tracing env var Ref: istio#20851 * Run make gen * Run make gen * Fix test added
brian-avery
pushed a commit
to brian-avery/istio
that referenced
this pull request
Mar 4, 2020
* Fix malformed stackdriver tracing env var Ref: istio#20851 * Run make gen * Run make gen * Fix test added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix malformed stackdriver tracing env var
Ref: #20851
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure