Skip to content

Fix extra .Value in deployment file for stackdriver tracing vars#21218

Closed
gargnupur wants to merge 1 commit intoistio:masterfrom
gargnupur:nup_fix_vars
Closed

Fix extra .Value in deployment file for stackdriver tracing vars#21218
gargnupur wants to merge 1 commit intoistio:masterfrom
gargnupur:nup_fix_vars

Conversation

@gargnupur
Copy link
Copy Markdown
Contributor

@gargnupur gargnupur commented Feb 18, 2020 •
edited by istio-policy-bot
Loading

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ X] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@gargnupur gargnupur requested a review from a team as a code owner February 18, 2020 18:35
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 18, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2020
@gargnupur gargnupur added cherrypick/release-1.5 and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2020
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2020
howardjohn
howardjohn requested changes Feb 18, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this needed for? these are legacy install charts that are about to be removed and do not support telemetry v2?

@gargnupur
Copy link
Copy Markdown
Contributor Author

gargnupur commented Feb 18, 2020

what is this needed for? these are legacy install charts that are about to be removed and do not support telemetry v2?

This was added in https://github.com/istio/istio/pull/21005/files#diff-e6fff6556e114913dd0fb810c79eaada and is not correct. So, fixing it so that we don't have wrong values.. if this file itself will be removed soon, then we can skip this PR.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Feb 18, 2020
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 18, 2020

@gargnupur: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 20, 2020

@gargnupur: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
unit-tests_istio 89d4674 link /test unit-tests_istio
integ-local-tests_istio 89d4674 link /test integ-local-tests_istio
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur
Copy link
Copy Markdown
Contributor Author

gargnupur commented Feb 25, 2020

Looks like this file is deleted for Istio 1.6. Will create a PR targeting 1.5 directly.

@gargnupur gargnupur closed this Feb 25, 2020
@gargnupur gargnupur deleted the nup_fix_vars branch February 25, 2020 21:04
@gargnupur gargnupur mentioned this pull request Feb 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn requested changes

+1 more reviewer

@bianpengyuan bianpengyuan bianpengyuan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/extensions and telemetry cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. needs-rebase Indicates a PR needs to be rebased before being merged size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gargnupur @istio-testing @howardjohn @bianpengyuan @googlebot @istio-policy-bot