Merged
Conversation
When collecting messages we include a quick check to remove any duplicates.
0aff202 to
d833d15
Compare
sushicw
approved these changes
Dec 5, 2019
Contributor
sushicw
left a comment
There was a problem hiding this comment.
I was going to suggest that if we had Message.Equals(), we could just have the context.messages be map[Message]bool instead of a slice and get deduping for free. Unfortunately, Go doesn't support that. :(
Contributor
Author
|
I considered doing that initially but decided not to as it would be a more invasive change. But now that you mention it, the fact that a |
Contributor
Author
|
/retest |
zerobfd
approved these changes
Dec 5, 2019
selmanj
added a commit
to selmanj/istio
that referenced
this pull request
Dec 6, 2019
Showing the namespace is redundant, as the relevant namespace will either be mentioned in the name of the policy object or the destination rule. Note that this will cause duplicate messages to appear since we still iterate over all namespaces (which is needed to find all misconfigurations). This isn't a problem now that we dedupe messages (istio#19419).
istio-testing
pushed a commit
that referenced
this pull request
Dec 6, 2019
Showing the namespace is redundant, as the relevant namespace will either be mentioned in the name of the policy object or the destination rule. Note that this will cause duplicate messages to appear since we still iterate over all namespaces (which is needed to find all misconfigurations). This isn't a problem now that we dedupe messages (#19419).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When collecting messages we include a quick check to remove any duplicates.