Remove namespace from mtls analyzer messages#19427
Merged
istio-testing merged 1 commit intoistio:masterfrom Dec 6, 2019
Merged
Remove namespace from mtls analyzer messages#19427istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
Showing the namespace is redundant, as the relevant namespace will either be mentioned in the name of the policy object or the destination rule. Note that this will cause duplicate messages to appear since we still iterate over all namespaces (which is needed to find all misconfigurations). This isn't a problem now that we dedupe messages (istio#19419).
sushicw
approved these changes
Dec 6, 2019
Contributor
Author
|
/test pilot-e2e-envoyv2-v1alpha3_istio |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showing the namespace is redundant, as the relevant namespace will either be mentioned in the name of the policy object or the destination rule.
Note that this will cause duplicate messages to be reported to
ctx.Reportsince we still iterate over all namespaces (which is needed to find all misconfigurations). This isn't a problem now that we dedupe messages (#19419).