move cross-cutting bazel defs out of //mixer and into the root directory#1900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1900 +/- ##
==========================================
- Coverage 81.2% 81.13% -0.08%
==========================================
Files 191 191
Lines 19455 19050 -405
==========================================
- Hits 15799 15456 -343
+ Misses 3194 3153 -41
+ Partials 462 441 -21
Continue to review full report at Codecov.
|
|
/lgtm |
|
@ZackButcher PR needs rebase |
…ory of the project
dfef459 to
70f2ea3
Compare
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @ZackButcher @douglas-reid @guptasu |
|
The bots either need to keep PRs up to date with master after approval or be able to diff a change and see it was a normal rebase. Having to get re-LGTMs after a PR is approved because we have a mono repo that's constantly changing is ridiculous cc @hklai @sebastienvas |
|
/retest |
|
How do we override codecov? We need to add logic to our check that doesn't fail if the delta is very small - I mean, 0.08% decrease in coverage, really? |
|
Ah I'm blind - codecov isn't required at least. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid, guptasu, rkpagadala The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
* send rbac shadow policies metrics to mixer * rename shadow -> permissive * address comments * address comments * address comments
This is the same as #1881; I didn't realize I made that change in my master branch, so when I brought master in line with istio/istio:master I overwrote the change/closed the PR.