Move cross-cutting bazel definitions up to the root of the project#1881
Move cross-cutting bazel definitions up to the root of the project#1881ZackButcher wants to merge 0 commit intoistio:masterfrom
Conversation
|
@mandarjog I could not find anywhere where the bazel version test file was used; do we run that manually to verify, or did I miss a BUILD rule somewhere that uses it? |
|
istio/istio should be mostly using the bazel protobuf rules from istio/api now, e.g. https://github.com/istio/api/blob/master/mixer/v1/config/descriptor/BUILD |
|
It is; the istio_api.bzl file is just the function that swaps between local or remote versions of the repo based on the flag in the WORKSPACE file. |
Codecov Report
@@ Coverage Diff @@
## master #1881 +/- ##
==========================================
- Coverage 81.23% 81.16% -0.08%
==========================================
Files 191 191
Lines 19344 19344
==========================================
- Hits 15715 15701 -14
- Misses 3173 3183 +10
- Partials 456 460 +4
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: douglas-reid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
…ory of the project (#1900) Automatic merge from submit-queue. move cross-cutting bazel defs out of //mixer and into the root directory This is the same as #1881; I didn't realize I made that change in my master branch, so when I brought master in line with istio/istio:master I overwrote the change/closed the PR. ```release-note NONE ```
…ory of the project (#1900) Automatic merge from submit-queue. move cross-cutting bazel defs out of //mixer and into the root directory This is the same as istio/istio#1881; I didn't realize I made that change in my master branch, so when I brought master in line with istio/istio:master I overwrote the change/closed the PR. ```release-note NONE ```
Rather than being burried under //mixer. This should also fix the build when using a local API repo (which used the relative path "../api", and would sometimes break).