remove lintconfig.json, that's generated#1869
remove lintconfig.json, that's generated#1869istio-merge-robot merged 6 commits intoistio:masterfrom
Conversation
|
/assign @guptasu |
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
- Coverage 81.9% 81.89% -0.01%
==========================================
Files 188 189 +1
Lines 18715 18721 +6
==========================================
+ Hits 15328 15332 +4
- Misses 2960 2961 +1
- Partials 427 428 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
- Coverage 81.23% 81.18% -0.06%
==========================================
Files 191 187 -4
Lines 19344 18778 -566
==========================================
- Hits 15715 15245 -470
+ Misses 3173 3106 -67
+ Partials 456 427 -29
Continue to review full report at Codecov.
|
generated_files
Outdated
| mixer/test/spyAdapter/template/report/go_default_library_handler.gen.go | ||
| mixer/test/spyAdapter/template/report/go_default_library_tmpl.pb.go | ||
| mixer/test/spyAdapter/template/template.gen.go | ||
| mixer/test/template/report/go_default_library_handler.gen.go |
There was a problem hiding this comment.
Bottom 3 files must be gone now. I think
There was a problem hiding this comment.
.gitignore
Outdated
| # pilot | ||
| pilot/platform/config | ||
| # lint | ||
| lintconfig.json |
There was a problem hiding this comment.
instead, should we just generated the temporary file in some /tmp dir ? replacing it every time the lint.sh script runs.
bin/bazel_to_go.py
Outdated
| conf = json.load(fin) | ||
| conf['exclude'].extend(manifest) | ||
| with open(os.path.join(WKSPC, "lintconfig.json"), "wt") as fout: | ||
| with open(os.path.join("/tmp", "istio-lintconfig.json"), "wt") as fout: |
There was a problem hiding this comment.
this might not work on mac. I usually have seen on Mac the temp did is named /T and not /tmp
There was a problem hiding this comment.
If there is no easy way to put the file in tmp dir, we can just leave it to what you had before... adding the file to the .ignore file. May be renamed it to istio-lintconfig.gen.json
There was a problem hiding this comment.
Well then, that's a bit hard; tempfile.gettempdir() can be used here, but the same path needs to be specified in linters.sh script, I'm not sure how it can be specified in a platform agnostic way; let me revert back for that part, and use lintconfig.gen.json name (I don't think istio- prefix is needed in that case, obviously it's for istio when it's within the workspace).
This reverts commit bb23aca.
|
/lgtm |
|
/assign @ldemailly |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guptasu, ldemailly The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Automatic merge from submit-queue. remove lintconfig.json, that's generated **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note none ```
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: