remove all bazel-genfiles for every presubmit build#1697
remove all bazel-genfiles for every presubmit build#1697jmuk wants to merge 4 commits intoistio:masterfrom
Conversation
Fixes istio#1689, all of the genfiles artifacts should be cleaned up. This can decrease the continuous build performance, although I hope the effect is tiny -- running codegen tools, recompiling some files, and re-linking the result (but most of the cases re-linking would happen anyways).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:You can indicate your approval by writing |
|
@yutongz can you check the performance effect on this PR? This should fix the problem, but the effect can be small, since it just removes the autogen files only. If the performance is okay, I think this solves the problem. |
|
Thanks, I will keep an eye on that. |
|
/retest |
|
First run failed with the same issue we had last friday and second run failed on auto-generated files. |
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
=========================================
- Coverage 81.22% 81.2% -0.03%
=========================================
Files 191 191
Lines 19455 19455
=========================================
- Hits 15803 15799 -4
- Misses 3192 3194 +2
- Partials 460 462 +2
Continue to review full report at Codecov.
|
|
Yeah, as Yutong said it looks like most recent failed on autogenerated files. could these have diverged back when the check was removed? |
|
Very weird, I have no idea how and where those |
|
/test istio-presubmit I cleaned the Prow cache, let try it again. |
|
/retest |
|
There is something wrong in master breaking presubmit for now. |
|
/retest |
1 similar comment
|
/retest |
|
@jmuk PR needs rebase |
|
/retest |
|
this is not necessary anymore, closing. |
Fixes #1689, all of the genfiles artifacts should be cleaned up.
This can decrease the continuous build performance, although
I hope the effect is tiny -- running codegen tools, recompiling
some files, and re-linking the result (but most of the cases
re-linking would happen anyways).
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #1689Special notes for your reviewer:
Release note: