Fix protoc.sh to output retry logging on stderr#18669
Merged
istio-testing merged 1 commit intoistio:masterfrom Nov 5, 2019
Merged
Fix protoc.sh to output retry logging on stderr#18669istio-testing merged 1 commit intoistio:masterfrom
istio-testing merged 1 commit intoistio:masterfrom
Conversation
geeknoid
approved these changes
Nov 5, 2019
Contributor
Author
|
/test e2e-simpleTests_istio |
howardjohn
approved these changes
Nov 5, 2019
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Nov 6, 2019
(cherry picked from commit bade502)
Merged
istio-testing
pushed a commit
that referenced
this pull request
Nov 7, 2019
sdake
pushed a commit
to sdake/istio
that referenced
this pull request
Dec 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mixer_codegen.shtreats any stdout as an error, so it ends up failing even if it succeeded on retry. (e.g. https://prow.istio.io/view/gcs/istio-prow/logs/gencheck_istio_postsubmit/404)This output should be on stderr anyway.