Skip to content

Fix gen-check flakes#18715

Merged
istio-testing merged 2 commits intoistio:release-1.4from
howardjohn:14/fix-gen
Nov 7, 2019
Merged

Fix gen-check flakes#18715
istio-testing merged 2 commits intoistio:release-1.4from
howardjohn:14/fix-gen

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Nov 6, 2019

Cherrypick of #18616 and a followup #18669

@sushicw @howardjohn
Add retry to protoc.sh (istio#18616)
27dcc5f 
* Add retry to protoc calls

* lint fix

(cherry picked from commit 57382cc)
@sushicw @howardjohn
Fix protoc.sh to output retry logging on stderr (istio#18669)
696ae7f 
(cherry picked from commit bade502)
@howardjohn howardjohn requested a review from a team November 6, 2019 22:34
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 6, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 6, 2019
@howardjohn
Copy link
Copy Markdown
Member Author

howardjohn commented Nov 7, 2019

/retest

@istio-testing istio-testing merged commit 0472f14 into istio:release-1.4 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwendell jwendell jwendell approved these changes

Assignees

@jwendell jwendell

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@howardjohn @jwendell @googlebot @istio-testing @sushicw