Merged
Conversation
Collaborator
|
Jenkins job istio/presubmit passed |
ayj
suggested changes
Apr 26, 2017
tests/e2e/apps/hop/app_test.go
Outdated
Contributor
There was a problem hiding this comment.
Slices are already reference types so the pointer is not necessary (see https://golang.org/doc/effective_go.html#slices).
tests/e2e/apps/hop/app_test.go
Outdated
Contributor
There was a problem hiding this comment.
I'm not sure this function is necessary. t.Error should be sufficient for logging errors in the test and output can be controlled with bazel using --test_output= flag.
tests/e2e/apps/hop/app_test.go
Outdated
Contributor
There was a problem hiding this comment.
(nit): unused receiver variable can be omitted and unused parameters leave unnamed, e.g.
func (errorServer) ServeHTTP(w http.ResponseWriter, _ *http.Request) {
tests/e2e/apps/hop/app_test.go
Outdated
Contributor
There was a problem hiding this comment.
Might be good to rename this t to something else in this file to avoid confusion with t *testing.T. Maybe ts and update the naming elsewhere to make the usage consistent?
tests/e2e/apps/hop/app_test.go
Outdated
Contributor
There was a problem hiding this comment.
tests/e2e/apps/hop/app.go
Outdated
Contributor
There was a problem hiding this comment.
You can return the return values of client.Hop directly, e.g.
return client.Hop(context.Background(), req)
tests/e2e/apps/hop/app.go
Outdated
Contributor
There was a problem hiding this comment.
Assignment and conditional check can be combined onto one line.
if _, err := w.Write()[]byte(jsonStr)); err != nil {
}
tests/e2e/apps/hop/app.go
Outdated
Contributor
There was a problem hiding this comment.
It might be good tag some of these tracing logs with verbose, i.e.
glog.V(2).Infof("...", arg, arg)
tests/e2e/apps/hop/app.go
Outdated
Contributor
There was a problem hiding this comment.
Use strings.TrimPrefix. It might also be more idiomatic to rewrite with an expressionless switch, i.e.
switch {
case strings.HasPrefix(d, "http://"):
return a.makeHTTPRequest(m, d)
case strings.HasPrefix(d, "grpc://"):
return a.makeGRPCRequest(m, strings.TrimPrefix(d, "grpc://"))
default:
return nil, errors.New("protocol not supported")
}
tests/e2e/apps/hop/app.go
Outdated
Contributor
There was a problem hiding this comment.
Do you want to accumulate errors or return the first error found? The former requires something like https://github.com/hashicorp/go-multierror. For the latter you can return the error immediately.
Collaborator
|
Jenkins job istio/presubmit passed |
ayj
reviewed
Apr 27, 2017
Contributor
ayj
left a comment
There was a problem hiding this comment.
General question: how does this fit into the bigger picture / how is it going to be used?
The golang looks mostly okay now. I didn't look too closely at bazel_to_go.py and the protobuf stuff since it never seems to make 100% sense even when I implement it myself.
tests/e2e/apps/hop/app.go
Outdated
Contributor
There was a problem hiding this comment.
err = multierror.Append(err, r.GetError())
tests/e2e/apps/hop/app_test.go
Outdated
tests/e2e/apps/hop/app_test.go
Outdated
Contributor
There was a problem hiding this comment.
(nit): The unused _ is more appropriate in the implementation on line 50 to show that the variable isn't used.
tests/e2e/apps/hop/app_test.go
Outdated
Contributor
There was a problem hiding this comment.
Slices are passed by reference. No need to return a pointer to a slice here.
bin/bazel_to_go.py
Outdated
Contributor
There was a problem hiding this comment.
It would be nice to unify this sort of script across all the repos. As it is now, mixer, manager, and istio all generate some version istio/api protobufs in slightly different ways. Is this something that could be abstracted away in a *.bzl in some common repo, e.g. istio/api?
Contributor
There was a problem hiding this comment.
I don't think we necessarily need to unify everything. Manager is using gazelle style imports while mixer is not. Mixer is doing funky stuff with proto gen while manager tries to keep it simple. We'll be combining complexity with little benefit to either of us.
Contributor
Author
There was a problem hiding this comment.
I am planning on looking at this after alpha.
Contributor
Author
|
I don't want to use the bookinfo for end to end test because it is moslty designed for demo. For testing we don't need eye candy. The Hop is actually helpful in a sense that testing routes works from the client point of view. No need to exec stuff from pods. |
Collaborator
|
Jenkins job istio/presubmit passed |
2 similar comments
Collaborator
|
Jenkins job istio/presubmit passed |
Collaborator
|
Jenkins job istio/presubmit passed |
sebastienvas
added a commit
that referenced
this pull request
May 4, 2017
* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change
rshriram
pushed a commit
that referenced
this pull request
Oct 30, 2017
* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change Former-commit-id: 0adf4c4
mandarjog
pushed a commit
that referenced
this pull request
Oct 31, 2017
* update test-infra version to upload coverage to GCS * Add exec permission for pkg_coverage.sh
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
* Initial version * Refactor for better testing * Update framework for testing and added test * Bazelify istio * Simplified interfaces * Refactor code to use Cleanable interface * go formating (#140) * go formating * Updated Jenkinsfile to run tests * Separate TestInfo to another module (#144) * Separete TestInfo to another module Implemented status file creation Implemented log upload to cloud storage Rename SetUp to Setup and TearDown to Teardown * Add more info in TestStatus * Rename InitLogging to InitGlog * Resolving comments * Return skipDir error on err * Adding Code Checks + Fix them (#151) * Not uploading logs_bucket_path flag is unset * Added code checks * Fix linter errors * Update Jenkins to use a goBuildNode * e2e test: Create namespace and deploy istio core and test app (#145) * Create namespace and deploy namespace * Get runtime source path * Correct pr comments, add GetGateWay() * Add default route test * Add version routing tests, fix linter and fix comments on pr * Add fault delay test and fix comments * Add version migration test * Add Hop App + testing (#162) * Implemented echo App * Adding test + refactoring * Added more tests * Resolved review comments * Use slices instead of pointers to slices * Fix formatting * Merge master to e2e (#165) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Small doc updates. (#163) * Demo test update + Docker file creation for Hop App (#172) * Renamed default env const * Added support for server update for version * Added a binary for Hop + Docker Image * WIP * Modified kubernetes setup + demo test * Fixed Jenkinsfile * Fix comments * Fix format * Removing app_flag as set directly in template * Fixed resp.close() was called on empty resp * Moved test to their own folder * Fixes e2e.sh * Make e2e.sh more verbose * Merge from istio:master, change install source to istio-install and setup istioctl (#175) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * Install istio from istio-install, add os x support and add setupIstioctl * fix lineter * Get rule files from demos/apps, istioctl cleanable and comments fix * small change * appManager cleanablization * Merge master to e2e (#181) * update version for testing (#147) Also update quota descriptors * Update copyright. * use lowercase zipkin trace headers (#152) * Add support for 1.6 with RBAC and change install to use one file. (#150) * Added RBAC roles and bindings * Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. To avoid confusion, auth will be added in separate PR * Update the tag for manager/proxy containers * Port forward manager service and enable istio manager env var Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Run service port-forward in the background and tidy it up Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add yaml template for manager into istio-16.yaml * Remove errant local Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver to istio manager deploy Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * added egress proxy to istio install folder to be referenced by istio.io docs * bug fix * Separate Istio CA installation from default. Istio CA should not be installed by default. Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the per-cluster and per-namespace CAs, so that users do not need to modify the files for different use cases. * Remove apiserver address Signed-off-by: LIAM White <liamwhite@uk.ibm.com> * Add apiserver and egress * Fix Istio CA files to create namespace. * Update one-off auth yaml files. * Small doc updates. (#163) * Improve Istio one-off yaml files for Istio auth. * Fix links. * Up the blanked rl to 5000, so it does not interfere with tests (#167) * Rename istio-ingress-controller to istio-ingress * Changed labels for ingress and ingress * update to rule schema to reflect switch from double to duration (#168) * update to rule schema to reflect switch from double to duration * pointed to my dockerhub * Updating istio version * Regenerate * Change in scripts * update to gcr.io/istio-testing versions (#170) 1. Update mixer, manager, proxy versions to include rate limit fixes 2. Remove mixer configmap. The default config is now baked inside mixer. 3. expose mixer metrics and configapi ports thru port forwarding. 4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full 5. ratelimit integration test. That PR will follow. * Add ingress service for correct status IP * Support for istio-ca in tests/updateVersion.sh (#180) * Update updateVersion.sh to take into account istio-ca * Updates with updateVersion.sh * Create README.md for e2e test framework (#182) * Create README.md for e2e test framework * small change Former-commit-id: 0adf4c4
mandarjog
pushed a commit
that referenced
this pull request
Nov 2, 2017
* update test-infra version to upload coverage to GCS * Add exec permission for pkg_coverage.sh
guptasu
pushed a commit
to guptasu/istio
that referenced
this pull request
Jun 11, 2018
Allow user to disable checks (but keep reports on) for mixer.
rajusharma
pushed a commit
to rajusharma/istio
that referenced
this pull request
Jul 2, 2019
howardjohn
pushed a commit
to howardjohn/istio
that referenced
this pull request
Jan 12, 2020
A couple notes: Any binary tool that needs to be used should first be installed in the istio/tools/docker/build-tools/Dockerfile. Any go generate should not compile, as this won't work cross platform.
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 26, 2020
istio#162) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
vikaschoudhary16
pushed a commit
to vikaschoudhary16/istio
that referenced
this pull request
Feb 12, 2021
…es (istio#162) Signed-off-by: Yaroslav Skopets <yaroslav@tetrate.io>
stevenctl
pushed a commit
to stevenctl/istio
that referenced
this pull request
Aug 13, 2022
* merge DSs and disable rp filter on iptables mode * remove ClusterFirstWithHostNet * fix render * new name * make ci happy * PR comments
antonioberben
pushed a commit
to antonioberben/istio
that referenced
this pull request
Jan 29, 2024
[jaeger-operator] Updated jaeger-operator to version 1.20.0
luksa
pushed a commit
to luksa/istio
that referenced
this pull request
Oct 14, 2024
…ter-merge_upstream_istio_master-6253864e Automator: merge upstream changes to openshift-service-mesh/istio@master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hop is composed of a client + server (HTTP, gRPC). A user defines a list of remotes destination, and the message will be routed accross all of them up to a failure and a status for each of the hop will be return. If any of the hop failed, the client will return failure.