Skip to content

Adding Code Checks + Fix them#151

Merged
sebastienvas merged 4 commits intoistio:e2efrom
sebastienvas:e2e
Apr 20, 2017
Merged

Adding Code Checks + Fix them#151
sebastienvas merged 4 commits intoistio:e2efrom
sebastienvas:e2e

Conversation

@sebastienvas
Copy link
Copy Markdown
Contributor

No description provided.

@istio-testing
Copy link
Copy Markdown
Collaborator

Jenkins job istio/presubmit passed

@sebastienvas sebastienvas merged commit e15e450 into istio:e2e Apr 20, 2017
@sebastienvas sebastienvas deleted the e2e branch April 20, 2017 23:29
sebastienvas added a commit that referenced this pull request May 4, 2017
* Initial version

* Refactor for better testing

* Update framework for testing and added test

* Bazelify istio

* Simplified interfaces

* Refactor code to use Cleanable interface

* go formating (#140)

* go formating

* Updated Jenkinsfile to run tests

* Separate TestInfo to another module (#144)

* Separete TestInfo to another module

Implemented status file creation
Implemented log upload to cloud storage
Rename SetUp to Setup and TearDown to Teardown

* Add more info in TestStatus

* Rename InitLogging to InitGlog

* Resolving comments

* Return skipDir error on err

* Adding Code Checks + Fix them (#151)

* Not uploading logs_bucket_path flag is unset

* Added code checks

* Fix linter errors

* Update Jenkins to use a goBuildNode

* e2e test: Create namespace and deploy istio core and test app (#145)

* Create namespace and deploy namespace

* Get runtime source path

* Correct pr comments, add GetGateWay()

* Add default route test

* Add version routing tests, fix linter and fix comments on pr

* Add fault delay test and fix comments

* Add version migration test

* Add Hop App + testing (#162)

* Implemented echo App

* Adding test + refactoring

* Added more tests

* Resolved review comments

* Use slices instead of pointers to slices

* Fix formatting

* Merge master to e2e (#165)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Small doc updates. (#163)

* Demo test update + Docker file creation for Hop App (#172)

* Renamed default env const

* Added support for server update for version

* Added a binary for Hop + Docker Image

* WIP

* Modified kubernetes setup + demo test

* Fixed Jenkinsfile

* Fix comments

* Fix format

* Removing app_flag as set directly in template

* Fixed resp.close() was called on empty resp

* Moved test to their own folder

* Fixes e2e.sh

* Make e2e.sh more verbose

* Merge from istio:master, change install source to istio-install and setup istioctl (#175)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Separate Istio CA installation from default.

Istio CA should not be installed by default.

Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the
per-cluster and per-namespace CAs, so that users do not need to modify the files
for different use cases.

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Fix Istio CA files to create namespace.

* Update one-off auth yaml files.

* Small doc updates. (#163)

* Improve Istio one-off yaml files for Istio auth.

* Fix links.

* Up the blanked rl to 5000, so it does not interfere with tests (#167)

* Rename istio-ingress-controller to istio-ingress

* Changed labels for ingress and ingress

* update to rule schema to reflect switch from double to duration (#168)

* update to rule schema to reflect switch from double to duration
* pointed to my dockerhub
* Updating istio version

* Regenerate

* Change in scripts

* Install istio from istio-install, add os x support and add setupIstioctl

* fix lineter

* Get rule files from demos/apps, istioctl cleanable and comments fix

* small change

* appManager cleanablization

* Merge master to e2e (#181)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Separate Istio CA installation from default.

Istio CA should not be installed by default.

Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the
per-cluster and per-namespace CAs, so that users do not need to modify the files
for different use cases.

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Fix Istio CA files to create namespace.

* Update one-off auth yaml files.

* Small doc updates. (#163)

* Improve Istio one-off yaml files for Istio auth.

* Fix links.

* Up the blanked rl to 5000, so it does not interfere with tests (#167)

* Rename istio-ingress-controller to istio-ingress

* Changed labels for ingress and ingress

* update to rule schema to reflect switch from double to duration (#168)

* update to rule schema to reflect switch from double to duration
* pointed to my dockerhub
* Updating istio version

* Regenerate

* Change in scripts

* update to gcr.io/istio-testing versions (#170)

1. Update mixer, manager, proxy versions to include rate limit fixes
2. Remove mixer configmap. The default config is now baked inside mixer.
3. expose mixer metrics and configapi ports thru port forwarding.
4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full
5. ratelimit integration test. That PR will follow.

* Add ingress service for correct status IP

* Support for istio-ca in tests/updateVersion.sh (#180)

* Update updateVersion.sh to take into account istio-ca

* Updates with updateVersion.sh

* Create README.md for e2e test framework (#182)

* Create README.md for e2e test framework

* small change
zenlint pushed a commit to zenlint/istio that referenced this pull request Aug 30, 2017
* First draft getting started

* Added istio-installation and changed bookinfo

* Fix display issue

* Addressed code review comments

* Address more review comments, istio-ca not part of the install

* Use local files instead of raw github files

* Addressed more review comments

* Added note about istioctl and renamed istio-ingress-controller to istio-ingress

* Fix the verb tense

* Rename istio-ingress-controller to istio-ingress

* Fixed installation instructions

* Remove fault injection

* Fix uninstall

* Fix link

* Correct path

* Rbac clarification for alpha and beta versions

* Add more clarity

* Add a dot

* Fix display error

* Fix display error

* Add clarification for Ingress

* Update installation to point to latest release

* Added instructions
rshriram pushed a commit that referenced this pull request Oct 30, 2017
* Initial version

* Refactor for better testing

* Update framework for testing and added test

* Bazelify istio

* Simplified interfaces

* Refactor code to use Cleanable interface

* go formating (#140)

* go formating

* Updated Jenkinsfile to run tests

* Separate TestInfo to another module (#144)

* Separete TestInfo to another module

Implemented status file creation
Implemented log upload to cloud storage
Rename SetUp to Setup and TearDown to Teardown

* Add more info in TestStatus

* Rename InitLogging to InitGlog

* Resolving comments

* Return skipDir error on err

* Adding Code Checks + Fix them (#151)

* Not uploading logs_bucket_path flag is unset

* Added code checks

* Fix linter errors

* Update Jenkins to use a goBuildNode

* e2e test: Create namespace and deploy istio core and test app (#145)

* Create namespace and deploy namespace

* Get runtime source path

* Correct pr comments, add GetGateWay()

* Add default route test

* Add version routing tests, fix linter and fix comments on pr

* Add fault delay test and fix comments

* Add version migration test

* Add Hop App + testing (#162)

* Implemented echo App

* Adding test + refactoring

* Added more tests

* Resolved review comments

* Use slices instead of pointers to slices

* Fix formatting

* Merge master to e2e (#165)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Small doc updates. (#163)

* Demo test update + Docker file creation for Hop App (#172)

* Renamed default env const

* Added support for server update for version

* Added a binary for Hop + Docker Image

* WIP

* Modified kubernetes setup + demo test

* Fixed Jenkinsfile

* Fix comments

* Fix format

* Removing app_flag as set directly in template

* Fixed resp.close() was called on empty resp

* Moved test to their own folder

* Fixes e2e.sh

* Make e2e.sh more verbose

* Merge from istio:master, change install source to istio-install and setup istioctl (#175)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Separate Istio CA installation from default.

Istio CA should not be installed by default.

Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the
per-cluster and per-namespace CAs, so that users do not need to modify the files
for different use cases.

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Fix Istio CA files to create namespace.

* Update one-off auth yaml files.

* Small doc updates. (#163)

* Improve Istio one-off yaml files for Istio auth.

* Fix links.

* Up the blanked rl to 5000, so it does not interfere with tests (#167)

* Rename istio-ingress-controller to istio-ingress

* Changed labels for ingress and ingress

* update to rule schema to reflect switch from double to duration (#168)

* update to rule schema to reflect switch from double to duration
* pointed to my dockerhub
* Updating istio version

* Regenerate

* Change in scripts

* Install istio from istio-install, add os x support and add setupIstioctl

* fix lineter

* Get rule files from demos/apps, istioctl cleanable and comments fix

* small change

* appManager cleanablization

* Merge master to e2e (#181)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Separate Istio CA installation from default.

Istio CA should not be installed by default.

Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the
per-cluster and per-namespace CAs, so that users do not need to modify the files
for different use cases.

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Fix Istio CA files to create namespace.

* Update one-off auth yaml files.

* Small doc updates. (#163)

* Improve Istio one-off yaml files for Istio auth.

* Fix links.

* Up the blanked rl to 5000, so it does not interfere with tests (#167)

* Rename istio-ingress-controller to istio-ingress

* Changed labels for ingress and ingress

* update to rule schema to reflect switch from double to duration (#168)

* update to rule schema to reflect switch from double to duration
* pointed to my dockerhub
* Updating istio version

* Regenerate

* Change in scripts

* update to gcr.io/istio-testing versions (#170)

1. Update mixer, manager, proxy versions to include rate limit fixes
2. Remove mixer configmap. The default config is now baked inside mixer.
3. expose mixer metrics and configapi ports thru port forwarding.
4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full
5. ratelimit integration test. That PR will follow.

* Add ingress service for correct status IP

* Support for istio-ca in tests/updateVersion.sh (#180)

* Update updateVersion.sh to take into account istio-ca

* Updates with updateVersion.sh

* Create README.md for e2e test framework (#182)

* Create README.md for e2e test framework

* small change

Former-commit-id: 0adf4c4
mandarjog pushed a commit that referenced this pull request Nov 2, 2017
* Initial version

* Refactor for better testing

* Update framework for testing and added test

* Bazelify istio

* Simplified interfaces

* Refactor code to use Cleanable interface

* go formating (#140)

* go formating

* Updated Jenkinsfile to run tests

* Separate TestInfo to another module (#144)

* Separete TestInfo to another module

Implemented status file creation
Implemented log upload to cloud storage
Rename SetUp to Setup and TearDown to Teardown

* Add more info in TestStatus

* Rename InitLogging to InitGlog

* Resolving comments

* Return skipDir error on err

* Adding Code Checks + Fix them (#151)

* Not uploading logs_bucket_path flag is unset

* Added code checks

* Fix linter errors

* Update Jenkins to use a goBuildNode

* e2e test: Create namespace and deploy istio core and test app (#145)

* Create namespace and deploy namespace

* Get runtime source path

* Correct pr comments, add GetGateWay()

* Add default route test

* Add version routing tests, fix linter and fix comments on pr

* Add fault delay test and fix comments

* Add version migration test

* Add Hop App + testing (#162)

* Implemented echo App

* Adding test + refactoring

* Added more tests

* Resolved review comments

* Use slices instead of pointers to slices

* Fix formatting

* Merge master to e2e (#165)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Small doc updates. (#163)

* Demo test update + Docker file creation for Hop App (#172)

* Renamed default env const

* Added support for server update for version

* Added a binary for Hop + Docker Image

* WIP

* Modified kubernetes setup + demo test

* Fixed Jenkinsfile

* Fix comments

* Fix format

* Removing app_flag as set directly in template

* Fixed resp.close() was called on empty resp

* Moved test to their own folder

* Fixes e2e.sh

* Make e2e.sh more verbose

* Merge from istio:master, change install source to istio-install and setup istioctl (#175)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Separate Istio CA installation from default.

Istio CA should not be installed by default.

Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the
per-cluster and per-namespace CAs, so that users do not need to modify the files
for different use cases.

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Fix Istio CA files to create namespace.

* Update one-off auth yaml files.

* Small doc updates. (#163)

* Improve Istio one-off yaml files for Istio auth.

* Fix links.

* Up the blanked rl to 5000, so it does not interfere with tests (#167)

* Rename istio-ingress-controller to istio-ingress

* Changed labels for ingress and ingress

* update to rule schema to reflect switch from double to duration (#168)

* update to rule schema to reflect switch from double to duration
* pointed to my dockerhub
* Updating istio version

* Regenerate

* Change in scripts

* Install istio from istio-install, add os x support and add setupIstioctl

* fix lineter

* Get rule files from demos/apps, istioctl cleanable and comments fix

* small change

* appManager cleanablization

* Merge master to e2e (#181)

* update version for testing (#147)

Also update quota descriptors

* Update copyright.

* use lowercase zipkin trace headers (#152)

* Add support for 1.6 with RBAC and change install to use one file. (#150)

* Added RBAC roles and bindings
* Script to generate merged configs for 1.5 and 1.6 - the 1.6 works wit rbac on or off. 

To avoid confusion, auth will be added in separate PR

* Update the tag for manager/proxy containers

* Port forward manager service and enable istio manager env var

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Run service port-forward in the background and tidy it up

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add yaml template for manager into istio-16.yaml

* Remove errant local

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver to istio manager deploy

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* added egress proxy to istio install folder to be referenced by istio.io docs

* bug fix

* Separate Istio CA installation from default.

Istio CA should not be installed by default.

Created istio-cluster-ca.yaml and istio-namespace-ca.yaml for deploying the
per-cluster and per-namespace CAs, so that users do not need to modify the files
for different use cases.

* Remove apiserver address

Signed-off-by: LIAM White <liamwhite@uk.ibm.com>

* Add apiserver and egress

* Fix Istio CA files to create namespace.

* Update one-off auth yaml files.

* Small doc updates. (#163)

* Improve Istio one-off yaml files for Istio auth.

* Fix links.

* Up the blanked rl to 5000, so it does not interfere with tests (#167)

* Rename istio-ingress-controller to istio-ingress

* Changed labels for ingress and ingress

* update to rule schema to reflect switch from double to duration (#168)

* update to rule schema to reflect switch from double to duration
* pointed to my dockerhub
* Updating istio version

* Regenerate

* Change in scripts

* update to gcr.io/istio-testing versions (#170)

1. Update mixer, manager, proxy versions to include rate limit fixes
2. Remove mixer configmap. The default config is now baked inside mixer.
3. expose mixer metrics and configapi ports thru port forwarding.
4. Add "wrk" for testing. drive traffic and fetch metrics as a setup for full
5. ratelimit integration test. That PR will follow.

* Add ingress service for correct status IP

* Support for istio-ca in tests/updateVersion.sh (#180)

* Update updateVersion.sh to take into account istio-ca

* Updates with updateVersion.sh

* Create README.md for e2e test framework (#182)

* Create README.md for e2e test framework

* small change

Former-commit-id: 0adf4c4
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Jan 12, 2020
* DNM: Next-Gen building system

This PR lints/builds/test all code using pinned tooling out of the
istio/tools repository.

This is part of the buildtools standardization effort.  Some of the
original makefile potentially contains cruft.  I could use some help
deteremining what is cruft and what is necessary for correct operation.

The goal of this work is to standardize our toolchain across all
deliverables of Istio.

* Address make mesh fails in docker environment
l8huang pushed a commit to l8huang/istio that referenced this pull request Jun 16, 2022
This is for fixing proxy SHA
stevenctl pushed a commit to stevenctl/istio that referenced this pull request Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants