filter: exposed functions to Lua to verify digital signature#76
Merged
duderino merged 7 commits intoistio:release-1.1from Jun 3, 2019
Merged
filter: exposed functions to Lua to verify digital signature#76duderino merged 7 commits intoistio:release-1.1from
duderino merged 7 commits intoistio:release-1.1from
Conversation
Signed-off-by: Yan Xue <yxyan@google.com>
Signed-off-by: Yan Xue <yxyan@google.com>
Signed-off-by: Yan Xue <yxyan@google.com>
Signed-off-by: Yan Xue <yxyan@google.com>
Signed-off-by: Yan Xue <yxyan@google.com>
Signed-off-by: Yan Xue <yxyan@google.com>
duderino
reviewed
Jun 3, 2019
| auto key = reinterpret_cast<EVP_PKEY*>(ptr); | ||
|
|
||
| // Step 2: initialize EVP_MD_CTX | ||
| EVP_MD_CTX* ctx = EVP_MD_CTX_new(); |
Member
Author
There was a problem hiding this comment.
It will not trigger any segment fault due to the implementation of both EVP_MD_CTX_free and EVP_DigestVerifyInit support passing NULL as a parameter.
EVP_MD_CTX_free will return if the parameter is NULL.
EVP_DigestVerifyInit will try to call EVP_MD_CTX_new again if the parameter is NULL. If the context is still NULL, the function will return 0.
|
We will drop this once the upstream Envoy PR is merged. @htuch says the API should be fine |
duderino
pushed a commit
to istio/proxy
that referenced
this pull request
Jun 4, 2019
* Update istio/envoy sha to pick up envoyproxy/envoy#6994 * Pick up istio/envoy#76
duderino
pushed a commit
to istio/istio
that referenced
this pull request
Jun 4, 2019
* Update istio/proxy for 1.1.8 * Import two additional istio/envoy commits. envoyproxy/envoy#6994 and istio/envoy#76
jplevyak
pushed a commit
to jplevyak/envoy
that referenced
this pull request
Dec 28, 2019
This can happen during certain early reply cases in the HCM when an encoder filter tries to lookup the cached route/cluster. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Expose functions for users to verify digital signature in Lua script
Risk Level: Low
Testing: unit test, integration
Docs Changes: https://github.com/envoyproxy/envoy/compare/master...crazyxy:feature/boringssllua?expand=1#diff-ddc999700fdafb43c2cdcafcc7a4b887
Release Notes: https://github.com/envoyproxy/envoy/compare/master...crazyxy:feature/boringssllua?expand=1#diff-d8d3e33358b55e6c0466dd1bb5f40c79
Fixes #Issue: envoyproxy#7009