Skip to content

Build 1.1.8 part 2#2259

Merged
duderino merged 2 commits intoistio:release-1.1from
duderino:jblatt_1_1_8c
Jun 4, 2019
Merged

Build 1.1.8 part 2#2259
duderino merged 2 commits intoistio:release-1.1from
duderino:jblatt_1_1_8c

Conversation

@duderino
Copy link
Copy Markdown

@duderino duderino commented Jun 3, 2019

Update istio/envoy sha to pick up https://github.com/envoyproxy/envoy//pull/6994 and istio/envoy#76

@istio-testing istio-testing requested a review from yxue June 3, 2019 20:32
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 3, 2019
@istio-testing istio-testing requested a review from JimmyCYJ June 3, 2019 20:32
@yxue
Copy link
Copy Markdown
Member

yxue commented Jun 3, 2019

/test proxy-presubmit

@yxue
Copy link
Copy Markdown
Member

yxue commented Jun 4, 2019

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazyxy, duderino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duderino duderino merged commit 102e286 into istio:release-1.1 Jun 4, 2019
@nrjpoddar
Copy link
Copy Markdown
Member

nrjpoddar commented Jun 5, 2019

@duderino we noticed that the macos build is always failing in release-1.1 branch. I think you need to cherry-pick parts or whole of this PR #2214 to make this build with pinned version of bazel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants