Add Mixer Report Session Affinity into Mesh Config#746
Add Mixer Report Session Affinity into Mesh Config#746istio-testing merged 2 commits intoistio:release-1.1from
Conversation
4d72cf1 to
7670a31
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bianpengyuan, geeknoid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| // Enable session affinity for envoy mixer reports so that calls from a proxy will | ||
| // always target the same mixer instance. | ||
| bool report_session_affinity = 31; |
There was a problem hiding this comment.
why does this have to have a config option? Also, this is very badly named.. It reads like "inform me of all the session affinity stuff in the mesh!"
There was a problem hiding this comment.
It controls telemetry cluster service discovery to be strict_dns or eds. For name, how about telemetry_report_session_affinity?
There was a problem hiding this comment.
sidecar_to_telemetry_session_affinity ?
Revive work introduced in istio/istio#8733.
@douglas-reid @mandarjog @kyessenov @geeknoid