Skip to content

WIP: Use k8s session affinity for istio-telemetry#8733

Closed
douglas-reid wants to merge 1 commit intoistio:masterfrom
douglas-reid:sticky-mixer
Closed

WIP: Use k8s session affinity for istio-telemetry#8733
douglas-reid wants to merge 1 commit intoistio:masterfrom
douglas-reid:sticky-mixer

Conversation

@douglas-reid
Copy link
Copy Markdown
Contributor

This PR alters the mixer plugin for Pilot by listening for outbound
clusters and then altering the definition of the mixer_report_server
cluster to use STRICT_DNS instead of EDS for service discovery. The
service address and port are provided as a singular host for use in
the cluster config. Finally, sessionAffinity: ClientIP is added to
the service.spec for istio-telemetry.

This PR is intended to provide sticky sessions between reporting pods
and the istio-telemetry service. This is motivated by requirements
from some telemetry systems (ex: Stackdriver) to receive telemetry for
a certain resource (here, the pod being monitored) in-order. While
this PR can help mitigate those requirements as a workaround, it is not
a complete solution and should not be viewed as such.

This PR is exploratory at the moment.

/hold

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. do-not-merge/hold Block automatic merging of a PR. labels Sep 14, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart

If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing
Copy link
Copy Markdown
Collaborator

@douglas-reid: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-unit-tests.sh 6ff516f link /test istio-unit-tests
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link
Copy Markdown

stale bot commented Sep 28, 2018

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Sep 28, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

@douglas-reid: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 21, 2018
@stale stale bot removed the stale label Oct 21, 2018
@stale
Copy link
Copy Markdown

stale bot commented Nov 5, 2018

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Block automatic merging of a PR. do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants