Skip to content

Merge missing commits from master to release-1.1#705

Merged
rshriram merged 14 commits intoistio:release-1.1from
rshriram:release-1.1
Nov 14, 2018
Merged

Merge missing commits from master to release-1.1#705
rshriram merged 14 commits intoistio:release-1.1from
rshriram:release-1.1

Conversation

@rshriram
Copy link
Copy Markdown
Member

Some PRs that affected both branches (such as tcp cluster rewrite,
trust domains etc.) went only into master but not release-1.1.
Since we are trying to pin down istio/istio:release-1.1 to istio/api:release-1.1,
we need the branches to be in sync (till date, istio/istio:release-1.1 was pointing
to istio/api:master).

24f6a07 (Shriram Rajagopalan, 6 days ago)
Update protolock
079096f (Shriram Rajagopalan, 6 days ago)
proto lock update
11e496c (Quanjie Lin, 7 days ago)
add trust domain to meshconfig (#697)
3215746 (Vadim Eisenberg, 9 days ago)
remove references to envoyproxy.io api-v1 (#694)
6b9e3a5 (Venil Noronha, 12 days ago)
Add TcpClusterRewrite config proto (#693)
bac7f54 (Jeff Mendoza, 12 days ago)
Merge mixer protos (#691)
d2dcf00 (Jeff Mendoza, 2 weeks ago)
Add prototool for linting, precommit, Circle, Prow. (#685)
011906d (Jeff Mendoza, 2 weeks ago)
Add Protolock. (#675)
4a0e55e (Pengyuan Bian, 3 weeks ago)
add stdduration annotation. (#673)

bianpengyuan and others added 13 commits October 26, 2018 16:01
* Add Protolock.

Move the protoc docker files to tools/protoc. Add docker files for
protolock image. Update Makefile precommit hook and prow presubmit
check to run protolock.

* Add combined image to be used on CircleCI

* Update proto.lock for policy_check_fail_open in mesh config.

* Updade circle config.
* Merge mixer protos.

* Remove renamed generated files.

* Regen mixer files

* Remove mixer lint exception.
This commit adds a TcpClusterRewrite proto to be used in the upcoming
TCP cluster rewrite filter on istio/proxy.

Signed-off-by: Venil Noronha <veniln@vmware.com>
in the latest envoyproxy.io (1.9) api-v1 was removed
* add trust domain to meshconfig

* fix build

* add comment
@googlebot
Copy link
Copy Markdown
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Nov 14, 2018
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Copy link
Copy Markdown
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit 05124e6 into istio:release-1.1 Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants