Conversation
Move the protoc docker files to tools/protoc. Add docker files for protolock image. Update Makefile precommit hook and prow presubmit check to run protolock.
|
Also, we will need to get |
|
@hklai @geeknoid PTAL. Jeff is introducing protolock (https://github.com/nilslice/protolock) into istio/api. |
|
Looks promising. |
Is the reason for the call to protolock in each Makefile entry? Can we remove it to expedite things? |
|
With circle, you might want to put all the tools into the base image for circle jobs. That would also work for prow, by the way. |
This is the recommended usage: This way if a developer runs The status command is taking ~20ms on my computer. |
Ah, hmm, it looks like the Circle config is using "gcr.io/istio-testing/protoc:2018-06-12" as the image. So, we will need an image with both protoc and protolock it seems. |
|
Perhaps we can use multi-stage builds to create a top-level image? I suspect we really want to version each tool separately. |
Sounds good. I'll add that |
|
Added |
|
Ok. Do you have permissions to upload the generated image to GCR? If not, @hklai can help there. |
|
No, I don't. |
|
@jeffmendoza I can add you to istio-testing so you can push, or I can clone this PR and do it myself (later today) if this PR is ready. Let me know. |
|
I'm happy to do it myself to lighten your load.
…On Wed, Oct 24, 2018, 11:52 AM Andy Lai ***@***.***> wrote:
@jeffmendoza <https://github.com/jeffmendoza> I can add you to
istio-testing so you can push, or I can clone this PR and do it myself
(later today) if this PR is ready.
Let me know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#675 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAvFO7h-48N8Ne5kHiOLpTiORMTetJVwks5uoLcGgaJpZM4X4UQ5>
.
|
|
/test api-presubmit |
|
Looks like prow is working. Circle CI config needs to be update to use the
@hklai Can you do this? |
|
That should be a config file .circleci folder. You should be able to update
this in your PR.
…On Wed, Oct 24, 2018 at 4:10 PM Jeff Mendoza ***@***.***> wrote:
Looks like prow is working.
Circle CI config needs to be update to use the
gcr.io/istio-testing/api-build-tools:2018-10-24 image instead of the
current one:
[image: ap-circle]
<https://user-images.githubusercontent.com/771387/47466674-32683300-d7a7-11e8-8448-d9dddfc243c5.png>
@hklai <https://github.com/hklai> Can you do this?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#675 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQR8I_XWZgnuGTxs-6msec0Qsq0_zuI6ks5uoPNOgaJpZM4X4UQ5>
.
|
|
@ozevren All CI config updated and passing. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ozevren The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Move the protoc docker files to tools/protoc. Add docker files for
protolock image. Update Makefile precommit hook and prow presubmit
check to run protolock.
The contents of
tools/protolockwill need to be built and pushed togcr.io/istio-testing/protolock:2018-10-23before merging for this PR to work.