Add TcpClusterRewrite config proto#693
Merged
rshriram merged 1 commit intoistio:masterfrom Nov 2, 2018
Merged
Conversation
Member
Author
|
/test api-presubmit |
This commit adds a TcpClusterRewrite proto to be used in the upcoming TCP cluster rewrite filter on istio/proxy. Signed-off-by: Venil Noronha <veniln@vmware.com>
2d84440 to
2ebfbc2
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
rshriram
approved these changes
Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
TcpClusterRewriteproto to be used in the upcoming TCP cluster rewrite filter onistio/proxy. This is purely envoy filter configuration and does not have any relation to end user facing Istio configuration. This filter will be used in multicluster routing scenarios, where traffic arriving at an ingress gateway can have DNS srv format for SNI values. The sni value is based on the service entry created in the remote cluster (e.g., foo.bar.global). This value needs to be rewritten to foo.bar.svc.cluster.local before being forwarded, so that we can utilize EDS. Otherwise, we would have to author 100s of virtual services where the virtual service has to account for different ports and services.@lizan felt that we should host this in istio/proxy until this filter sees widespread usage, before it can be moved to Envoy.
Signed-off-by: Venil Noronha veniln@vmware.com