Skip to content

Cherry pick PRs from master#676

Merged
rshriram merged 6 commits intoistio:release-1.1from
rshriram:release-1.1
Oct 25, 2018
Merged

Cherry pick PRs from master#676
rshriram merged 6 commits intoistio:release-1.1from
rshriram:release-1.1

Conversation

@rshriram
Copy link
Copy Markdown
Member

@rshriram rshriram commented Oct 24, 2018

Changes:

9e5a917 (Yangmin Zhu, 22 hours ago)
Add mesh config to allow setting network policy fail open (#670)
3f8c1a7 (Ozben Evren, 24 hours ago)
Update OWNERS (#671)

e23ad3b (Shriram Rajagopalan, 2 days ago)
MCP server configuration (#669)
0b1e20c (Yossi Mesika, 3 days ago)
Added MeshNetworks (#666)

b3f5d5d (Shriram Rajagopalan, 3 days ago)
Updating description of network definitions (#664)

rshriram and others added 5 commits October 21, 2018 09:40
@rshriram
Updating description of network definitions (istio#664)
b3f5d5d 
* clarity

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* renaming

* nits

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@ymesika @rshriram
Added MeshNetworks (istio#666)
0b1e20c
@rshriram
MCP server configuration (istio#669)
e23ad3b 
* MCP server configuration

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* nits

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
@ozevren @geeknoid
Update OWNERS (istio#671)
3f8c1a7
@yangminzhu @mandarjog
Add mesh config to allow setting network policy fail open (istio#670)
9e5a917
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Oct 24, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Oct 24, 2018
frankbu
frankbu approved these changes Oct 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Oct 25, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit 0fc221c into istio:release-1.1 Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm

@mandarjog mandarjog Awaiting requested review from mandarjog

1 more reviewer

@frankbu frankbu frankbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@frankbu frankbu

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rshriram @googlebot @istio-testing @frankbu @ymesika @ozevren @yangminzhu