Conversation
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
| // protocol (MCP). Can be IP address or a fully qualified DNS name. | ||
| string address = 1; | ||
|
|
||
| // Use the tls_settings to specify the tls mode to use. If the MCP server |
There was a problem hiding this comment.
Please note: we need to specify TLS settings here because ultil we talk to a MCP server, we can't get destination rules etc. Also, these settings are for Pilot internal implementation (go/mtls, etc.) and not meant for Envoy. So, asking people to specify a destination rule will create bootstrap issues within Pilot code.
ZackButcher
left a comment
There was a problem hiding this comment.
LGTM, worth thinking about resurrecting the full oneof for the different config types (k8s, file system, MCP server, etc), but I think we can get by with just a simple address to start with.
| message ConfigSource { | ||
| // Address of the server implementing the Istio Mesh Configuration | ||
| // protocol (MCP). Can be IP address or a fully qualified DNS name. | ||
| // Use file:/// to specify a file-based backend with absolute path to the directory. |
There was a problem hiding this comment.
| // Use file:/// to specify a file-based backend with absolute path to the directory. | |
| // Use file:// to specify a file-based backend with absolute path to the directory. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Shriram Rajagopalan shriramr@vmware.com