Skip to content

Add mesh config to allow setting network policy fail open#670

Merged
mandarjog merged 1 commit intoistio:masterfrom
yangminzhu:failOpenOption
Oct 23, 2018
Merged

Add mesh config to allow setting network policy fail open#670
mandarjog merged 1 commit intoistio:masterfrom
yangminzhu:failOpenOption

Conversation

@yangminzhu
Copy link
Copy Markdown
Contributor

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 23, 2018
@istio-testing istio-testing requested a review from hklai October 23, 2018 18:36
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyessenov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu
Copy link
Copy Markdown
Contributor Author

@rshriram Could you help to merge this? Do we need this in both 1.1 and the potential 1.0.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants