IRISHUB-323: finish the query of GovParameter#234
Merged
wukongcheng merged 40 commits intoirisnet:feature/govfrom Sep 18, 2018
MrXJC:jiacheng/gov
Merged
IRISHUB-323: finish the query of GovParameter#234wukongcheng merged 40 commits intoirisnet:feature/govfrom MrXJC:jiacheng/gov
wukongcheng merged 40 commits intoirisnet:feature/govfrom
MrXJC:jiacheng/gov
Conversation
Sync with develop
…r bank, coin and auth
Sync with develop
…/irisnet/irishub/client/lcd/statik
…_docs to update_irislcd_swagger_docs
… feature/lcd-dev-1
Code structure: context.go, query.go and version related apis
merge Feature/gov to Develop
Merge with develop
Pull code from feature/lcd to develop
IRISHUB-352: add irisdebug tool
merge develop into feature/irisdebug & addr add hex
merge feature/irisdebug into develop
iriscli命令行接口实现
Merge code from feature/lcd to develop
wukongcheng
reviewed
Sep 17, 2018
client/gov/cli/query.go
Outdated
| @@ -244,10 +246,10 @@ func GetCmdQueryConfig(storeName string, cdc *wire.Codec) *cobra.Command { | |||
| Short: "query parameter proposal's config", | |||
Contributor
There was a problem hiding this comment.
what's the difference between this cmd and the 'GetCmdQueryGovConfig' ? who call the 'GetCmdQueryConfig' ?
Contributor
Author
There was a problem hiding this comment.
'GetCmdQueryConfig' is the previous method. I could delete it.
wukongcheng
suggested changes
Sep 17, 2018
Contributor
wukongcheng
left a comment
There was a problem hiding this comment.
keep one of the two 'query-params'
wukongcheng
approved these changes
Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.