iriscli命令行接口实现#225
Merged
wukongcheng merged 11 commits intoirisnet:feature/lcdfrom Sep 17, 2018
HaoyangLiu:feature/lcd-dev-1
Merged
iriscli命令行接口实现#225wukongcheng merged 11 commits intoirisnet:feature/lcdfrom HaoyangLiu:feature/lcd-dev-1
wukongcheng merged 11 commits intoirisnet:feature/lcdfrom
HaoyangLiu:feature/lcd-dev-1
Conversation
added 11 commits
September 14, 2018 16:57
… feature/lcd-dev-1
wukongcheng
reviewed
Sep 17, 2018
| return err | ||
| } | ||
|
|
||
| acc, err := cliCtx.GetAccount(key) |
Contributor
There was a problem hiding this comment.
convert to iris instead of atto
wukongcheng
reviewed
Sep 17, 2018
| if err != nil { | ||
| utils.WriteErrorResponse(w, http.StatusInternalServerError, err.Error()) | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
think about how to reuse these duplicated code in every rest api
wangjiulian
pushed a commit
that referenced
this pull request
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://jira.bianjie.ai/browse/IRISHUB-357
jira任务重构过，所以commit中写的jira ID可能不对