Add explicit argtype counting, required for osx-arm64.#12804
Merged
Carreau merged 3 commits intoipython:masterfrom Feb 2, 2021
Merged
Add explicit argtype counting, required for osx-arm64.#12804Carreau merged 3 commits intoipython:masterfrom
Carreau merged 3 commits intoipython:masterfrom
Conversation
Member
|
Thanks for diving into this ! How's the M1 ? |
meeseeksmachine
pushed a commit
to meeseeksmachine/ipython
that referenced
this pull request
Feb 2, 2021
Contributor
Author
|
Thanks for your quick response! Sadly I don't have an M1, still on the DTK until I get all my essential code ported. |
Thanks for fixing this! The M1 is absolutely fabulous. Completely disruptive. I can't see how Intel or AMD are going to survive this. x86 has run its course. |
Carreau
added a commit
that referenced
this pull request
Feb 4, 2021
…804-on-7.x Backport PR #12804 on branch 7.x (Add explicit argtype counting, required for osx-arm64.)
Jofkos
added a commit
to Jofkos/PyDev.Debugger
that referenced
this pull request
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #12803 ipython crashes when loading matplotlib (or any windowing plugin) when running on Apple Silicon (arm64) macs. This PR fixes the crash by adding explicit argument counts when calling out to objc, which should have been there before, but are required for osx-arm64. (See also minrk/appnope#7 ).