Merged
Conversation
erykoff
reviewed
Nov 28, 2020
appnope/_nope.py
Outdated
|
|
||
| # Needed to init ObjC, otherwise C('NSString') returns None | ||
| # TODO: Investigate why and include a better fix. | ||
| from urllib.request import urlopen |
There was a problem hiding this comment.
Instead of this line, we need to do _ = ctypes.cdll.LoadLibrary(ctypes.util.find_library('Foundation')) after the objc library load. I think this should have been there all along (as the framework to interface with c code).
Contributor
Author
|
To whoever maintains this, I feel good about this PR now with the hack removed. |
erykoff
added a commit
to erykoff/appnope-feedstock
that referenced
this pull request
Nov 29, 2020
…ersions). Thanks to George Hotz minrk/appnope#7
5 tasks
Owner
|
Awesome, thanks! Will release later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the segfault in IPython