Merged
Conversation
e1662ca to
35db1a4
Compare
35db1a4 to
0d57edb
Compare
iand
approved these changes
Jul 20, 2022
Contributor
iand
left a comment
There was a problem hiding this comment.
LGTM, some minor typos in tests
68d8236 to
7d7faed
Compare
This adds a missing test for #3963
This fixes a regression around directory listing and index.html hosting. Seems that during one of recent refactors code changed and we no longer check for trailing slash in HTTP request path, but look at content path instead. This cleans this up and also ensures dir behavior is the same for both index.html hosting and dir-index-html (generated listing). It also adds more tests so we catch any future regressions.
7d7faed to
3182986
Compare
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
…xfs-dirs fix(gw): directory URL normalization This commit was moved from ipfs/kubo@cf82ae5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr
This PR fixes a regression around directory listing and index.html hosting,
and makes Kubo behavior compliant with desired Gateway Specs here.
Why
Seems that during one of recent refactors code changed and we no longer check for trailing slash in HTTP request path. Most likely, this happened when we switched from raw URL path to content path.
This regression meant Kubo was not following specs at
/ipfs/specs/http-gateways/PATH_GATEWAY.md#use-in-directory-url-normalization.
What
This PR:
/ipfs/cid/footo/ipfs/cid/foo/