gateway: don't redirect to trailing slash if it's go get#3963
Merged
whyrusleeping merged 1 commit intomasterfrom Jun 9, 2017
Merged
gateway: don't redirect to trailing slash if it's go get#3963whyrusleeping merged 1 commit intomasterfrom
whyrusleeping merged 1 commit intomasterfrom
Conversation
This enables `go get` to parse go-import meta tags from index.html files stored in IPFS. One tiny step toward whyrusleeping/gx-go#2. For an import like `ipfs.io/ipfs/QmFoo/mypkg`, the gateway would previously redirect to `/ipfs/QmFoo/mypkg/` (note the trailing slash), which the `go get` tool can't deal with. Thankfully, `go get` sets a URL query parameter (`?go-get=1`) which we can use to switch off the redirect in this case. License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
whyrusleeping
approved these changes
Jun 9, 2017
Member
whyrusleeping
left a comment
There was a problem hiding this comment.
LGTM, thanks @lgierth :)
lidel
added a commit
that referenced
this pull request
Jul 18, 2022
This adds a missing test for #3963
lidel
added a commit
that referenced
this pull request
Jul 18, 2022
This adds a missing test for #3963
lidel
added a commit
that referenced
this pull request
Jul 21, 2022
This adds a missing test for #3963
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
gateway: don't redirect to trailing slash if it's go get This commit was moved from ipfs/kubo@67828a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables
go getto parse go-import meta tags from index.html files stored in IPFS. One tiny step toward whyrusleeping/gx-go#2.For an import like
ipfs.io/ipfs/QmFoo/mypkg, the gateway would previously redirect to/ipfs/QmFoo/mypkg/(note the trailing slash), which thego gettool can't deal with. Thankfully,go getsets a URL query parameter (?go-get=1) which we can use to switch off the redirect in this case.