Skip to content

feat(pinning): add Scaleway pinning service#2132

Merged
SgtPooki merged 3 commits intoipfs:mainfrom
vmscw:main
Sep 19, 2023
Merged

feat(pinning): add Scaleway pinning service#2132
SgtPooki merged 3 commits intoipfs:mainfrom
vmscw:main

Conversation

@vmscw
Copy link
Contributor

@vmscw vmscw commented Jun 22, 2023

No description provided.

@vmscw vmscw requested a review from a team as a code owner June 22, 2023 16:16
@welcome
Copy link

welcome bot commented Jun 22, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki
Copy link
Member

SgtPooki commented Jul 14, 2023

blocked by resolution of ipfs-shipyard/pinning-service-compliance#299

@SgtPooki SgtPooki marked this pull request as draft July 14, 2023 22:12
@SgtPooki SgtPooki added the status/blocked Unable to be worked further until needs are met label Jul 14, 2023
@SgtPooki SgtPooki marked this pull request as ready for review September 12, 2023 22:27
@SgtPooki
Copy link
Member

SgtPooki commented Sep 12, 2023

@vmscw i'm good to merge this one now since ipfs-shipyard/pinning-service-compliance#333 was merged, but the scaleway logo doesn't seem to be resolving: https://dweb.link/ipfs/QmQnbWQCw4YKn53hTizARdMacvw6b3yFCqpQEPrSxVgXXL

@SgtPooki SgtPooki merged commit 0cc3b04 into ipfs:main Sep 19, 2023
ipfs-gui-bot pushed a commit that referenced this pull request Dec 2, 2023
@semantic-release-bot
chore(release): 4.2.0 [skip ci]
951c7bd 
## [4.2.0](v4.1.1...v4.2.0) (2023-12-02)

 CID `bafybeidf7cpkwsjkq6xs3r6fbbxghbugilx3jtezbza7gua3k5wjixpmba`

 ---

### Features

* peers table can be filtered ([#2181](#2181)) ([37b5880](37b5880))
* **pinning:** add Scaleway pinning service ([#2132](#2132)) ([0cc3b04](0cc3b04))

### Bug Fixes

* error loading scaleway template URL ([7a3388e](7a3388e))
* replace estuary with web3 for pinning ([#2182](#2182)) ([e2fc7c8](e2fc7c8))
* status page supports webrtc ([#2180](#2180)) ([ff75d4e](ff75d4e)), closes [#1965](#1965)
* switch to new dnslink updater ([#2175](#2175)) ([a63f48a](a63f48a))

### Trivial Changes

* Pull transifex translations ([#2162](#2162)) ([c0f8f54](c0f8f54))
* pull transifex translations ([#2177](#2177)) ([7f377ff](7f377ff))
* update release transifex links ([74cce69](74cce69))
@ipfs-gui-bot
Copy link
Collaborator

ipfs-gui-bot commented Dec 2, 2023

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

SgtPooki added a commit to ipfs/kubo that referenced this pull request Dec 2, 2023
@SgtPooki
chore: webui v4.2.0 [skip changelog]
e9c2c9f 
## [4.2.0](ipfs/ipfs-webui@v4.1.1...v4.2.0) (2023-12-02)


 CID `bafybeidf7cpkwsjkq6xs3r6fbbxghbugilx3jtezbza7gua3k5wjixpmba`

 --- 



### Features

* peers table can be filtered ([#2181](ipfs/ipfs-webui#2181)) ([37b5880](ipfs/ipfs-webui@37b5880))
* **pinning:** add Scaleway pinning service ([#2132](ipfs/ipfs-webui#2132)) ([0cc3b04](ipfs/ipfs-webui@0cc3b04))


### Bug Fixes

* error loading scaleway template URL ([7a3388e](ipfs/ipfs-webui@7a3388e))
* replace estuary with web3 for pinning ([#2182](ipfs/ipfs-webui#2182)) ([e2fc7c8](ipfs/ipfs-webui@e2fc7c8))
* status page supports webrtc ([#2180](ipfs/ipfs-webui#2180)) ([ff75d4e](ipfs/ipfs-webui@ff75d4e)), closes [#1965](ipfs/ipfs-webui#1965)
* switch to new dnslink updater ([#2175](ipfs/ipfs-webui#2175)) ([a63f48a](ipfs/ipfs-webui@a63f48a))


### Trivial Changes

* Pull transifex translations ([#2162](ipfs/ipfs-webui#2162)) ([c0f8f54](ipfs/ipfs-webui@c0f8f54))
* pull transifex translations ([#2177](ipfs/ipfs-webui#2177)) ([7f377ff](ipfs/ipfs-webui@7f377ff))
* update release transifex links ([74cce69](ipfs/ipfs-webui@74cce69))
@SgtPooki SgtPooki mentioned this pull request Dec 2, 2023
Merged
lidel
lidel reviewed Dec 3, 2023
View reviewed changes
src/constants/pinning.js
name: 'Scaleway',
icon: 'https://dweb.link/ipfs/QmQnbWQCw4YKn53hTizARdMacvw6b3yFCqpQEPrSxVgXXL',
apiEndpoint: 'https://<your-volume-region-code>.ipfs.labs.scw.cloud/<your-volume-id>/',
visitServiceUrl: 'https://www.scaleway.com/en/docs/labs/ipfs/api-cli/ipfs-desktop/'
Copy link
Member

@lidel lidel Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SgtPooki cosmetic, but https://www.scaleway.com/en/docs/labs/ipfs/api-cli/ipfs-desktop/ returns 404

Copy link
Member

@SgtPooki SgtPooki Dec 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmscw is this the correct url?

@lidel lidel mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidel lidel lidel left review comments

+1 more reviewer

@SgtPooki SgtPooki SgtPooki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released status/blocked Unable to be worked further until needs are met

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vmscw @SgtPooki @ipfs-gui-bot @lidel @OnsagerHe