Skip to content

fix(app, android): react-native 0.65 compatibility#5616

Merged
mikehardy merged 2 commits intomasterfrom
@mikehardy/rn65-compatibility
Aug 20, 2021
Merged

fix(app, android): react-native 0.65 compatibility#5616
mikehardy merged 2 commits intomasterfrom
@mikehardy/rn65-compatibility

Conversation

@mikehardy
Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy commented Aug 19, 2021 •
edited
Loading

Description

As discovered by @wfern we appear to have a missing couple of APIs needed by react-native 0.65

This will hopefully fix that

Test Plan

Hopefully someone can try the patch set (available from this URL - https://github.com/invertase/react-native-firebase/suites/3536859145/artifacts/84635700 - grabbed from the "artifacts" dropdown from the details link on the patches action below 👇 ) - integrate it with https://github.com/ds300/patch-package and should work?

Related issues

Fixes #5614

Release Summary

conventional commits --> rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/EcTJoDgik3WYtz2r82rfozqnvm1B
✅ Preview: https://react-native-firebase-git-mikehardy-rn65-compa-a42069-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/3G4gWo7k1EBB5qrE5tqHTkdmHVB7
✅ Preview: Canceled

[Deployment for acfc895 canceled]

@mikehardy mikehardy mentioned this pull request Aug 19, 2021
Closed
10 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2021 •
edited
Loading

Codecov Report

Merging #5616 (a0ef0e8) into master (8bd3a1c) will decrease coverage by 19.43%.
The diff coverage is 60.00%.

❗ Current head a0ef0e8 differs from pull request most recent head acfc895. Consider uploading reports for the commit acfc895 to get more accurate results

@@              Coverage Diff              @@
##             master    #5616       +/-   ##
=============================================
- Coverage     73.11%   53.68%   -19.42%     
- Complexity        0      631      +631     
=============================================
  Files           109      208       +99     
  Lines          4476    10076     +5600     
  Branches        954     1543      +589     
=============================================
+ Hits           3272     5408     +2136     
- Misses         1126     4384     +3258     
- Partials         78      284      +206

@wfern
Copy link
Copy Markdown

wfern commented Aug 19, 2021

Yes, that's exactly what I meant. I tested it the way you described here and everything works fine.
Thank you very much for creating the pull-request.

@mikehardy
Copy link
Copy Markdown
Collaborator Author

mikehardy commented Aug 19, 2021

It's about to be my overnight here so I won't be able to test it for a little while but I'll merge + release tomorrow if everything goes well, while working through #5611

@mikehardy mikehardy mentioned this pull request Aug 19, 2021
Closed
@mikehardy mikehardy force-pushed the @mikehardy/rn65-compatibility branch from f9d66a5 to ef060fe Compare August 20, 2021 00:25
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 20, 2021 00:25 Inactive
@mikehardy mikehardy force-pushed the @mikehardy/rn65-compatibility branch from ef060fe to acfc895 Compare August 20, 2021 02:10
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 20, 2021 02:10 Inactive
@mikehardy
Copy link
Copy Markdown
Collaborator Author

mikehardy commented Aug 20, 2021

upstream react-native re-wrote the EventEmitter infrastructure, and it's not too hard to work with the new style for RN65+ but it's a bit touchy to handle either RN <= 64 and RN >= 65 at the same time, working through that now then I can release

@mikehardy mikehardy merged commit 262452d into master Aug 20, 2021
@mikehardy mikehardy deleted the @mikehardy/rn65-compatibility branch August 20, 2021 02:38
This was referenced Aug 20, 2021
Merged
Closed
Closed
@wfern wfern mentioned this pull request Aug 22, 2021
Closed
3 tasks
This was referenced Aug 23, 2021
Merged
Merged
piaskowyk pushed a commit to software-mansion/react-native-reanimated that referenced this pull request Aug 23, 2021
@mikehardy
fix(android): react-native 0.65 event emitter stubs (#2316)
1714680 
## Description

Fixes #2297 by adding stub implementations of newly-required
methods from react-native 0.65

See e.g. 

- react-native-device-info/react-native-device-info@3917f33
- invertase/react-native-firebase#5616
@mikehardy mikehardy mentioned this pull request Aug 24, 2021
Closed
@vegaro vegaro mentioned this pull request Dec 6, 2021
Closed
5 tasks
@adgang adgang mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🔥🐛] RN 0.65 compatibility coming with react-native-firebase v12.7.1

2 participants

@mikehardy @wfern