Skip to content

test(e2e): update e2e test app to react-native 0.65#5611

Merged
mikehardy merged 1 commit intomasterfrom
@mikehardy/rn65-update
Aug 20, 2021
Merged

test(e2e): update e2e test app to react-native 0.65#5611
mikehardy merged 1 commit intomasterfrom
@mikehardy/rn65-update

Conversation

@mikehardy
Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy commented Aug 18, 2021 •
edited
Loading

Description

Update our test app to react-native 0.65

  • error in local javascript console about a synchronous react-native method being invoked, which doesn't work in chrome debugger (chrome debugger protocol is used by Jet)? May be e2e tests app bug - unable to track this down, does not seem to matter?
  • error in metro bundler console about a symbolicate file not found? May be a jet bug? Looked like a URL with only one slash after protocol not two, for the source map URL? Does not seem to matter

Related issues

Peeled this from #5590 so that one isn't blocked on something less important since it did not work immediately
Verified it with results of #5616 (it was built on that until a moment ago in fact, just re-based it out)

Release Summary

conventional commit (when ready), rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Local and CI runs of all tests should pass

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 18, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/CMTtqm31JUdWQW8epxMUM25Hhvs5
✅ Preview: https://react-native-firebase-git-mikehardy-rn65-update-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/4vFAcPEVt1egGBRQgc5SrioLt7YJ
✅ Preview: Canceled

[Deployment for 64a7729 canceled]

@mikehardy mikehardy marked this pull request as draft August 18, 2021 16:42
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2021 •
edited
Loading

Codecov Report

Merging #5611 (56cd8f3) into master (262452d) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 56cd8f3 differs from pull request most recent head 64a7729. Consider uploading reports for the commit 64a7729 to get more accurate results

@@             Coverage Diff              @@
##             master    #5611      +/-   ##
============================================
+ Coverage     53.68%   53.70%   +0.02%     
- Complexity      631      632       +1     
============================================
  Files           208      208              
  Lines         10076    10076              
  Branches       1543     1543              
============================================
+ Hits           5408     5410       +2     
+ Misses         4384     4383       -1     
+ Partials        284      283       -1

@mikehardy mikehardy mentioned this pull request Aug 18, 2021
Merged
8 tasks
@mikehardy mikehardy force-pushed the @mikehardy/rn65-update branch from d73f582 to bc31f91 Compare August 18, 2021 18:45
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 18, 2021 18:45 Inactive
@wfern
Copy link
Copy Markdown

wfern commented Aug 18, 2021

Hello @mikehardy , I have been getting the warning in the console about "new NativeEventEmitter() ..." being called without the listeners methods. I think this is because of the change in the commit 114be1d. The NativeEmitter is being called here RNFBNativeEventEmitter.js.
I don't know if this is the right place to help. Would it be better if I open an issue?

@mikehardy
Copy link
Copy Markdown
Collaborator Author

mikehardy commented Aug 18, 2021

Hello @mikehardy , I have been getting the warning in the console about "new NativeEventEmitter() ..." being called without the listeners methods. I think this is because of the change in the commit 114be1d. The NativeEmitter is being called here RNFBNativeEventEmitter.js.
I don't know if this is the right place to help. Would it be better if I open an issue?

Definitely a new issue if you can

@wfern
Copy link
Copy Markdown

wfern commented Aug 18, 2021

@mikehardy I dig some more and create the issue. Thanks.

@mikehardy mikehardy mentioned this pull request Aug 19, 2021
Merged
8 tasks
@mikehardy mikehardy force-pushed the @mikehardy/rn65-update branch from bc31f91 to c188163 Compare August 20, 2021 00:24
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 20, 2021 00:24 Inactive
@mikehardy mikehardy force-pushed the @mikehardy/rn65-update branch from c188163 to eeb1647 Compare August 20, 2021 02:10
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 20, 2021 02:10 Inactive
@mikehardy
build(deps): bump test app to react-native 0.65.1
64a7729 
- includes all the changes from upgrade-helper
- remove Podfile post_install minimum iOS version convergence
  this seems to be an anti-pattern now, Folly+iOS at least fails
  to compile with this stanza included
@mikehardy mikehardy force-pushed the @mikehardy/rn65-update branch from eeb1647 to 64a7729 Compare August 20, 2021 02:39
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 20, 2021 02:39 Inactive
@mikehardy mikehardy marked this pull request as ready for review August 20, 2021 02:42
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Aug 20, 2021
@mikehardy mikehardy changed the title test(e2e): update e2e test app to react-native 0.65 WIP test(e2e): update e2e test app to react-native 0.65 Aug 20, 2021
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 20, 2021
@mikehardy mikehardy merged commit 89fb79a into master Aug 20, 2021
@mikehardy mikehardy deleted the @mikehardy/rn65-update branch August 20, 2021 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikehardy @wfern