Skip to content

Temporary logging to debug script group bug#248

Merged
Zakaria-Kofiro merged 6 commits intomasterfrom
zkofiro/script-group-fix
Jul 11, 2023
Merged

Temporary logging to debug script group bug#248
Zakaria-Kofiro merged 6 commits intomasterfrom
zkofiro/script-group-fix

Conversation

@Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented Jul 5, 2023

title: Temporary logging to debug script group bug

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro changed the title Temporary fix for adding script to script group bug Temporary logging to debug script group bug Jul 11, 2023
@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review July 11, 2023 21:27
<context-param>
<param-name>javax.faces.PROJECT_STAGE</param-name>
<param-value>Production</param-value>
<param-value>Development</param-value>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zakaria-Kofiro Can you explain the reason for this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is a change Kevin suggested where setting this from Production to Development enables error messages logs that wouldn't normally appear if set to Production, to help with debugging. Basically enables additional logging.

https://stackoverflow.com/questions/19193912/uses-of-javax-faces-project-stage

@shawn-h-park shawn-h-park self-requested a review July 11, 2023 22:18
@Zakaria-Kofiro Zakaria-Kofiro merged commit 7abc93d into master Jul 11, 2023
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/script-group-fix branch July 11, 2023 22:26
Zakaria-Kofiro pushed a commit that referenced this pull request Jul 14, 2023
Zakaria-Kofiro added a commit that referenced this pull request Jul 14, 2023
* script group fix - set component to not load dynamically

* Revert "Temporary logging to debug script group bug (#248)"

This reverts commit 7abc93d.

---------

Co-authored-by: zkofiro <zakaria_kofiro@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants