Script Group AJAX Fix- set component to not load dynamically#251
Merged
Zakaria-Kofiro merged 3 commits intomasterfrom Jul 14, 2023
Merged
Script Group AJAX Fix- set component to not load dynamically#251Zakaria-Kofiro merged 3 commits intomasterfrom
Zakaria-Kofiro merged 3 commits intomasterfrom
Conversation
shawn-h-park
approved these changes
Jul 14, 2023
added 2 commits
July 13, 2023 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script Group AJAX Fix- set component to not load dynamically
The intial fix for the script group dialogue component issue, where ajax calls are reloading cached Javascript files and stalling the page. Setting the component to not load dynamically will ensure all components are loaded beforehand to successfully complete the AJAX calls. This fix will only affect that specific component.
Please make sure these check boxes are checked before submitting
mvn clean test -P default** PR review process **