WEBDEV-8100 Encapsulate style settings#22
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 60.00% 60.00%
=======================================
Files 5 5
Lines 45 45
Branches 5 5
=======================================
Hits 27 27
Misses 15 15
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbuckner
left a comment
There was a problem hiding this comment.
Ahhh I love this! 🫶 Thanks for doing this! A few suggestions, but overall looks great!
|
Just thinking out loud here, not for this MR, but it'd be great to have something similar to this for component properties as well... ie |
@jbuckner 100%! That was one of my bigger motivations in doing this encapsulation, I figured it would help start to set the standards for doing something similar with properties, which will be more complicated, but I think definitely doable. I'll try to do some similar local consolidation where possible as I add more properties to the status indicator to experiment with what kinds of things would work before doing a full encapsulation |
|
Oh something I just noticed.. can we hide the |
We definitely can! I was being lazy and was going to leave that to the property extraction portion of the job (similarly to how the styles section isn't displayed if there are no styles, but I can add a workaround for now if you think we need it. |
Ah that's fine! Not needed now! |
Oops I already did it! But it was good further practice re: dealing with slots and should be easy to switch out. |
* main: v0.1.0 (#26) WEBDEV-8109 Expand status indicator capabilities (#23) WEBDEV-8100 Encapsulate style settings (#22) Load snowflakes async (#12) WEBDEV-8019 Add basic loading indicator (#17) Fix issue with css property values not updating (#19) WEBDEV-8098: Component Demo Light Mode (#18) WEBDEV-8037 Create CSS theme structure (#16)
* main: Update directory paths for GitHub Pages (#27) WEBDEV-8141: Github Pages (#25) v0.1.0 (#26) WEBDEV-8109 Expand status indicator capabilities (#23) WEBDEV-8100 Encapsulate style settings (#22) Load snowflakes async (#12) WEBDEV-8019 Add basic loading indicator (#17) Fix issue with css property values not updating (#19) WEBDEV-8098: Component Demo Light Mode (#18) WEBDEV-8037 Create CSS theme structure (#16)
Encapsulates the style settings options into the story template, so consumers don't have to build out the inputs individually