WEBDEV-8019 Add basic loading indicator#17
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
===========================================
+ Coverage 34.61% 45.16% +10.54%
===========================================
Files 3 4 +1
Lines 26 31 +5
Branches 4 4
===========================================
+ Hits 9 14 +5
Misses 15 15
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eab45ca to
fd8e6d7
Compare
|
I looked into and conducted research for this particular loading. I found that SVG loading indicators shouldn’t rely on <title> or for assistive technology. Instead, the loading state should be communicated via an ARIA role on the container, such as role="status or role="progressbar". The <title> / elements mainly create tooltips, which aren’t relevant for this use case. A better approach is to provide context using an ARIA label or a screen-reader-only text like Loading, please wait…. Since the loading state is already described textually, the SVG itself can be marked as decorative using aria-hidden="true". Here is an example of what a loader SVG would look like. |
|
Thanks @nsharma123! I'll do some more research myself (if you have sources for your research, that would be great) and look into switching out that title. |
Thanks @nsharma123 ! I did some research in a11y resources and the MDN docs and determined that the best approach was to use the Made both changes -- thanks for bringing this up and I'm excited to get more a11y work into this new repo. |
jbuckner
left a comment
There was a problem hiding this comment.
Two comments (and can remove that light/dark switch), but looks good 👍
7d48dcd to
69041f0
Compare
* main: v0.1.0 (#26) WEBDEV-8109 Expand status indicator capabilities (#23) WEBDEV-8100 Encapsulate style settings (#22) Load snowflakes async (#12) WEBDEV-8019 Add basic loading indicator (#17) Fix issue with css property values not updating (#19) WEBDEV-8098: Component Demo Light Mode (#18) WEBDEV-8037 Create CSS theme structure (#16)
* main: Update directory paths for GitHub Pages (#27) WEBDEV-8141: Github Pages (#25) v0.1.0 (#26) WEBDEV-8109 Expand status indicator capabilities (#23) WEBDEV-8100 Encapsulate style settings (#22) Load snowflakes async (#12) WEBDEV-8019 Add basic loading indicator (#17) Fix issue with css property values not updating (#19) WEBDEV-8098: Component Demo Light Mode (#18) WEBDEV-8037 Create CSS theme structure (#16)
As part of the migration of the
ia-activity-indicatorinto the elements repo, we're first building the svg and CSS animations for the loading indicator and then expanding it into a more fully-featuredia-status-indicatorthat can show a loading, error, or success indicator depending on amodeproperty.This PR simply builds the first basic loading indicator.