[NFCI][SYCL] Remove Reduction::getOutPointer#7184
Merged
steffenlarsen merged 1 commit intointel:syclfrom Oct 27, 2022
Merged
Conversation
Both USM pointers/accessors work with operator[] just fine.
aelovikov-intel
added a commit
to aelovikov-intel/llvm-test-suite
that referenced
this pull request
Oct 25, 2022
Contributor
Author
|
/verify with intel/llvm-test-suite#1348 |
steffenlarsen
approved these changes
Oct 26, 2022
Contributor
steffenlarsen
left a comment
There was a problem hiding this comment.
LGTM! Small comment, but it is not blocking.
| // Each of local accessors keeps two partial sums: in | ||
| // 0-th and WGsize-th elements. Combine them into final | ||
| // partial sums and write to output accessors. | ||
| BOp(LocalReds[0], LocalReds[WGSize]); |
Contributor
There was a problem hiding this comment.
Uff! Those comments are really messing with the formatter. Might it make sense to move the comments to before the statement and combine them? Say something like:
If it is a uniform work-group with a power-of-two size, ..., otherwise ...
Contributor
Author
There was a problem hiding this comment.
I agree clang-format did something weird here, but, IMO, it's not that bad. I plan more refactoring, will see if can come up with something in one of next PRs.
v-klochkov
approved these changes
Oct 26, 2022
steffenlarsen
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Oct 27, 2022
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both USM pointers/accessors work with operator[] just fine.