[SYCL] Bugfix for unexpected acceptance of id argument in nd_range pa…#1348
Merged
[SYCL] Bugfix for unexpected acceptance of id argument in nd_range pa…#1348
Conversation
fb984f1 to
d5a4225
Compare
romanovvlad
reviewed
Mar 19, 2020
f8eca84 to
5bc8bac
Compare
…rallel_for Signed-off-by: Bing1 Yu <bing1.yu@intel.com>
5bc8bac to
dea62f8
Compare
romanovvlad
approved these changes
Mar 27, 2020
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel callable being invoked from an nd_range parallel_for is accepting an id argument, while it should be nd_item.
After my analysis, I found we check arguments' type for kernel_parallel_for instead of parallel_for. But that check is useless, because the compiler can still find a candidate for kernel_parallel_for with nd_range&id which is a wrong combination.
In my solution, parallel_for with nd_range calls kernel_parallel_for_nd_range(...) which is only available for nd_item.
Signed-off-by: Bing1 Yu bing1.yu@intel.com