[SYCL][Graph][UR] Rename cmd-buf enqueue entry-point #16984
Merged
sommerlukas merged 1 commit intointel:syclfrom Mar 6, 2025
Merged
[SYCL][Graph][UR] Rename cmd-buf enqueue entry-point #16984sommerlukas merged 1 commit intointel:syclfrom
sommerlukas merged 1 commit intointel:syclfrom
Conversation
4237ced to
91e3208
Compare
0d2edb2 to
4408c4c
Compare
4408c4c to
aa24647
Compare
aa24647 to
67e68e7
Compare
67e68e7 to
4271718
Compare
4271718 to
f6215b3
Compare
f6215b3 to
26dcd77
Compare
26dcd77 to
6dff0b2
Compare
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
b1f8a1f to
36b3867
Compare
kbenzie
approved these changes
Mar 4, 2025
againull
approved these changes
Mar 4, 2025
Seanst98
approved these changes
Mar 5, 2025
keyradical
approved these changes
Mar 5, 2025
coldav
approved these changes
Mar 6, 2025
Contributor
Author
|
@intel/llvm-gatekeepers This is good to merge, thanks |
lukaszstolarczuk
added a commit
to lukaszstolarczuk/compute-benchmarks
that referenced
this pull request
Mar 12, 2025
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 14, 2025
`urCommandBufferEnqueueExp` was changed in intel#16984 to `urEnqueueCommandBufferExp`
uditagarwal97
pushed a commit
that referenced
this pull request
Mar 14, 2025
kbenzie
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Mar 17, 2025
`urCommandBufferEnqueueExp` was changed in intel/llvm#16984 to `urEnqueueCommandBufferExp` but added back accidentally to the v2 L0 adapter in intel/llvm#17297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same PR as was closed in #16747 due to CI issue #16982 which has since been resolved.
The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions.
This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS.
Closes UR issue oneapi-src/unified-runtime#2600