Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp#2606
Merged
kbenzie merged 1 commit intooneapi-src:mainfrom Feb 6, 2025
Merged
Rename urCommandBufferEnqueueExp to urEnqueueCommandBufferExp#2606kbenzie merged 1 commit intooneapi-src:mainfrom
kbenzie merged 1 commit intooneapi-src:mainfrom
Conversation
d96133f to
aec66e8
Compare
aec66e8 to
c62847a
Compare
pbalcer
approved these changes
Jan 23, 2025
aarongreig
approved these changes
Jan 23, 2025
hvdijk
approved these changes
Jan 24, 2025
keyradical
reviewed
Jan 29, 2025
keyradical
approved these changes
Jan 29, 2025
Contributor
Author
|
ping @oneapi-src/unified-runtime-hip-write & @oneapi-src/unified-runtime-cuda-write for review |
steffenlarsen
approved these changes
Jan 30, 2025
steffenlarsen
left a comment
There was a problem hiding this comment.
CUDA and HIP changes look pretty simple. LGTM!
The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions. This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS. Closes oneapi-src#2600
2bb9744 to
ec5a3bd
Compare
pbalcer
approved these changes
Feb 3, 2025
yingcong-wu
pushed a commit
to yingcong-wu/llvm
that referenced
this pull request
Feb 11, 2025
Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
EwanC
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Feb 11, 2025
…e_refactor" This reverts commit cc60d08, from oneapi-src#2606 due to CI fails in the DPC++ bump PR that need further investigation intel/llvm#16747
kbenzie
added a commit
that referenced
this pull request
Feb 11, 2025
Revert "Merge pull request #2606 from Bensuo/cmd-buf_enqueue_refactor"
EwanC
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Feb 12, 2025
**Same patch as oneapi-src#2606 which was reverted due to intel/llvm#16982 The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions. This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS. Closes oneapi-src#2600
EwanC
pushed a commit
to Bensuo/unified-runtime
that referenced
this pull request
Feb 18, 2025
**Same patch as oneapi-src#2606 which was reverted due to intel/llvm#16982 The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions. This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS. Closes oneapi-src#2600
Chenyang-L
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 18, 2025
This reverts commit cc60d08, from oneapi-src/unified-runtime#2606 due to CI fails in the DPC++ bump PR that need further investigation #16747
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 4, 2025
**Same PR as was closed in intel#16747 due to intel#16982 Reflects change in name of UR entry-point from `urCommandBufferEnqueueExp` to `urEnqueueCommandBufferExp` in oneapi-src/unified-runtime#2606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API to enqueue a closed command-buffer to a queue is defined in the YAML as a part of the command-buffer class, but it should be part of the enqueue class like other enqueue API extensions.
This PR updates the YAML and regenerates UR code, making the associated changes to adapters and CTS.
DPC++ PR intel/llvm#16747
Closes #2600