[SYCL] Add experimental flag to enable front-end optimizations#1376
Merged
bader merged 2 commits intointel:syclfrom Mar 25, 2020
Merged
[SYCL] Add experimental flag to enable front-end optimizations#1376bader merged 2 commits intointel:syclfrom
bader merged 2 commits intointel:syclfrom
Conversation
Fznamznon
reviewed
Mar 24, 2020
Fznamznon
previously approved these changes
Mar 24, 2020
NOTE: This flag is not exposed to the driver and not intended for users. It's added to make experiments and identify issues with optimizations. Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Signed-off-by: Alexey Bader <alexey.bader@intel.com>
Fznamznon
reviewed
Mar 25, 2020
| @@ -1,4 +1,4 @@ | |||
| // RUN: %clang_cc1 -fsycl -fsycl-is-device -triple spir64-unknown-unknown-sycldevice -emit-llvm -x c++ %s -o - | FileCheck %s | |||
| // RUN: %clang_cc1 -fsycl -fsycl-is-device -fsycl-enable-optimizations -triple spir64-unknown-unknown-sycldevice -emit-llvm -x c++ %s -o - | FileCheck %s | |||
Contributor
There was a problem hiding this comment.
I don't get this change. If you want to test your new option, add specific test for it. I don't see why you adding this option to unrelated test and check noting.
Contributor
Author
There was a problem hiding this comment.
It's explained in the commit message.
"[SYCL] Update the test checking optimized LLVM IR"
Contributor
There was a problem hiding this comment.
Ok, I see. No more questions about the change.
We added a test checking optimized IR. Does such test makes sense if we don't enable optimizations when compiling SYCL application?
Contributor
Author
There was a problem hiding this comment.
It still makes sense because it has a few checks matching asm, which are relevant as target independent optimizations do not optimize inline asm.
Contributor
Author
There was a problem hiding this comment.
Although I agree that it would be better to re-write the checks.
Fznamznon
approved these changes
Mar 25, 2020
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Mar 27, 2020
…hinx * upstream/sycl: (357 commits) [Support] Implement a simple tabular data management library (intel#1358) [Support] Implement a property set I/O library (intel#1357) [SYCL] Fix buffer constructor using iterators (intel#1386) [SYCL][FPGA] Enable a set of loop attributes (intel#1312) [Driver][SYCL][FPGA] Proper dependency output location when given /Fo<dir> (intel#1346) [SPIR-V] Enabling SPIR-V builtin lookup in device SYCL mode (intel#1384) [SYCL][NFC] Unify setting kernel arguments (intel#1379) [SYCL][Doc] First revision of standard layout relaxation extension (intel#1344) [SYCL] Fixed sub-buffer alloca search (intel#1385) [SYCL][FPGA] Emit multiple IR variants for the IVDep attribute (intel#1383) [SYCL] Add experimental flag to enable front-end optimizations (intel#1376) [SYCL] Remove unexpected double in complex SPIR-V for float support (intel#1381) [SYCL] Default work-group sizes based on max (intel#952) [SYCL][CUDA] Fix usage of multiple backends in the same program (intel#1252) [SPIR-V] Add SPIR-V builtin definitions to the builtin lookup. [SPIR-V] Add macro definition when -fdeclare-spirv-builtins is activated [SYCL] Fix sycl_generic printing [SYCL] Support intel::reqd_work_group_size (intel#1328) [SYCL][NFC] Make the RT::PiPlugin object private (intel#1375) [SPIRV] Add convergent attribute to SPIR-V built-ins (intel#1373) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This flag is not exposed to the driver and not intended for users.
It's added to make experiments and identify issues with optimizations.
Signed-off-by: Alexey Bader alexey.bader@intel.com