[SYCL][Graph] E2E tests for SYCL Graphs (4/4)#10216
Merged
steffenlarsen merged 23 commits intointel:syclfrom Jul 28, 2023
Merged
[SYCL][Graph] E2E tests for SYCL Graphs (4/4)#10216steffenlarsen merged 23 commits intointel:syclfrom
steffenlarsen merged 23 commits intointel:syclfrom
Conversation
- Adds E2E tests for SYCL Graphs
Matching implementation change to specification PR #255
- Fix an issue in the inconsistent device test where if a CUDA device was selected the test would terminate due to the CUDA backend stubs - Adjusted to always use the level zero device for making the command buffer
CI has discovered some failing Graphs E2E tests on Windows. Either mark them XFAIL or skip them until we can investigate and fix.
Contributor
|
I believe @steffenlarsen has been reviewing graph PRs, so it would make sense for him to look at this one as well. |
- Unify tests where possible. - Test code moved to Inputs folder and actual lit tests define an API and include the input file - Added missing tests for some APIs which have a counterpart in the other and are not API specific - New common functions which are API agnostic for adding diamond dependency nodes - New API agnostic function for adding single nodes - API selected by defining GRAPH_E2E_<EXPLICIT/RECORD_REPLAY> before including test input Some tests have been removed as being unnecessary due to testing almost identical functionality to other tests. Also removed the reduction regression test since reductions are pretty well covered in the E2E tests already and they were redundant. --------- Co-authored-by: Pablo Reble <pablo.reble@intel.com>
- Simplify dotp refrence in common header - Remove use of gpu_selector_v - Simplify dotp_usm_reduction init kernel - Make dotp test values constexpr
reble
approved these changes
Jul 28, 2023
steffenlarsen
approved these changes
Jul 28, 2023
Contributor
steffenlarsen
left a comment
There was a problem hiding this comment.
Only one small open, but otherwise it looks good!
Contributor
Author
|
The pre-commit workflow failure on HIP appears to be a CI wide issue affecting multiple PRs and unrelated to this PR specifically. I've reported the issue in #10615 |
Contributor
|
Since none of the tests are intended to run on HIP, I believe this is good to merge. |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
# E2E Tests for SYCL Graphs This is the fourth patch of a series that adds support for an [experimental command graph extension](intel#5626) A snapshot of the complete work can be seen in draft PR intel#9375 which has support all the specification defined ways of adding nodes and edges to the graph, including both Explicit and Record & Replay graph construction. The two types of nodes currently implemented are kernel execution and memcpy commands. See https://github.com/reble/llvm#implementation-status for the status of our total work. ## Scope This fourth patch focuses on adding E2E tests for SYCL Graphs, covering the following: * Record and Replay API based tests. * Explicit API based tests. * Thread safety tests. * A small amount of miscellaneous tests. ## Following Split PRs Future follow-up PRs with the remainder of our work on the extension will include: * NFC changes - Design doc. ## Authors Co-authored-by: Pablo Reble <pablo.reble@intel.com> Co-authored-by: Julian Miller <julian.miller@intel.com> Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> Co-authored-by: Ewan Crawford <ewan@codeplay.com> Co-authored-by: Maxime France-Pillois <maxime.francepillois@codeplay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E Tests for SYCL Graphs
This is the fourth patch of a series that adds support for an experimental command graph extension
A snapshot of the complete work can be seen in draft PR #9375 which has support all the specification defined ways of
adding nodes and edges to the graph, including both Explicit and Record & Replay graph construction. The two types of nodes currently implemented are kernel execution and memcpy commands.
See https://github.com/reble/llvm#implementation-status for the status of our total work.
Scope
This fourth patch focuses on adding E2E tests for SYCL Graphs, covering the following:
Following Split PRs
Future follow-up PRs with the remainder of our work on the extension will include:
Authors
Co-authored-by: Pablo Reble pablo.reble@intel.com
Co-authored-by: Julian Miller julian.miller@intel.com
Co-authored-by: Ben Tracy ben.tracy@codeplay.com
Co-authored-by: Ewan Crawford ewan@codeplay.com
Co-authored-by: Maxime France-Pillois maxime.francepillois@codeplay.com