This repository was archived by the owner on Mar 2, 2026. It is now read-only.
[SYCL][Graph] Unify tests where possible#275
Merged
reble merged 14 commits intosycl-graph-patch-4from Jul 26, 2023
Merged
Conversation
- Unify tests which use common header kernel functions that are mostly identical between APIs - Test code moved to Inputs folder and actual lit tests define an API and include the input file - Added missing tests for some APIs which have a counterpart in the other and are not API specific - New common functions which are API agnostic for adding diamond dependency nodes - New API agnostic function for adding single nodes - API selected by defining GRAPH_E2E_<EXPLICIT/RECORD_REPLAY> before including test input
- Many dotp/usm tests removed and replaced with basic_* versions since they were almost identical - Other tests unified
- Unify more tests - Remove some unncessary tests - Replace DEPENDS_ON macro with templated function
sycl/test-e2e/Graph/RecordReplay/subgraph_interleaved_submit.cpp
Outdated
Show resolved
Hide resolved
julianmi
reviewed
Jul 25, 2023
sycl/test-e2e/Graph/RecordReplay/subgraph_interleaved_submit.cpp
Outdated
Show resolved
Hide resolved
- Rename some tests for better clarity - Unify more subgraph tests - Fix various small issues
mfrancepillois
approved these changes
Jul 26, 2023
julianmi
approved these changes
Jul 26, 2023
reble
reviewed
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests have been removed as being unnecessary due to testing almost identical functionality to other tests. I've also removed the reduction regression test test since reductions are pretty well covered in the E2E tests already and we're not testing anything special.