Export branches attribute of github_repository resource#959
Export branches attribute of github_repository resource#959jcudit merged 1 commit intointegrations:mainfrom
branches attribute of github_repository resource#959Conversation
In integrations#892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
branches attribute of github_repository resource
|
We recently started using the GitHub provider and this missing feature is unfortunately a blocker for us. Checking the PR it looks pretty straightforward. :) Please let me know if there's anything we can do to help get this merged and released! Would love to contribute if we can. |
|
Getting the list of branches from the resource will be really helpful. +1 on making this available. |
I've never seen this codebase before, so I'm not sure why my name came up 😅 |
My bad! I checked what team owned this repo and your profile popped up. Any idea whom one could talk to about merging this in? It's a tiny, straightforward change and it'd make such a difference for us! 🙏 |
Which team is that?
Sorry I don't have clue, my team doesn't own anything to do with this hence my confusion. |
The GitHub integrations team. You're one of four people listed and the only one with a Staff badge. :) |
|
Fascinating, unfortunately I don't even have permission to merge your PR 😅 |
|
@integrations/integrations-reviewers is this in your AoR? |
|
@jcudit Is this considered a BC break or why the major bump? :) Maybe im missing something with how these milestones are used. |
|
@tobiassjosten my mistake and thanks for bringing this back to my attention. Will get this linked to the next upcoming minor release! |
In integrations#892, the newly-added `branches` attribute was exported for the data source, but not the resource. This exports `branches` in the resource too.
In #892, the newly-added
branchesattribute was exported for the data source, but not the resource. This results in an error as noted in #892 (comment). This PR exports thebranchesattribute in the resource too.I considered adding a test, but it looks like a branch might need to exist, and in cases where multiple branches exist, the order of the branch names might not be deterministic. So I tested this manually by using the built provider in a Terraform project using
dev_overrides.